Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: test/cctest/test-ast.cc

Issue 2638783002: Revert of [Parser] Introduce AstStringConstants to share constants across AstValueFactory (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/asmjs/test-asm-typer.cc ('k') | test/cctest/test-parsing.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-ast.cc
diff --git a/test/cctest/test-ast.cc b/test/cctest/test-ast.cc
index c027e88a525ac84b6e27be4d41ca0339a46b1ebe..99cbb950ca27cb040ab3ff30f7ad3ce03dd040f3 100644
--- a/test/cctest/test-ast.cc
+++ b/test/cctest/test-ast.cc
@@ -30,7 +30,6 @@
#include "src/v8.h"
#include "src/ast/ast.h"
-#include "src/isolate.h"
#include "src/objects-inl.h"
#include "src/zone/accounting-allocator.h"
#include "test/cctest/cctest.h"
@@ -38,16 +37,12 @@
using namespace v8::internal;
TEST(List) {
- v8::V8::Initialize();
- Isolate* isolate = CcTest::i_isolate();
-
List<AstNode*>* list = new List<AstNode*>(0);
CHECK_EQ(0, list->length());
v8::internal::AccountingAllocator allocator;
Zone zone(&allocator, ZONE_NAME);
- AstValueFactory value_factory(&zone, isolate->ast_string_constants(),
- isolate->heap()->HashSeed());
+ AstValueFactory value_factory(&zone, 0);
AstNodeFactory factory(&value_factory);
AstNode* node = factory.NewEmptyStatement(kNoSourcePosition);
list->Add(node);
« no previous file with comments | « test/cctest/asmjs/test-asm-typer.cc ('k') | test/cctest/test-parsing.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698