Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8142)

Unified Diff: chrome/common/logging_chrome.cc

Issue 2638763004: Report CHECK/DCHECK to test launcher summary output. (Closed)
Patch Set: Add comment. Fix missed usage of SetLogAssertHandler. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/logging_chrome.cc
diff --git a/chrome/common/logging_chrome.cc b/chrome/common/logging_chrome.cc
index e9e51b130ea2b85aa63275000f81fbe022f939cd..8a01c7008844513854bd88629073dbf99a03d84e 100644
--- a/chrome/common/logging_chrome.cc
+++ b/chrome/common/logging_chrome.cc
@@ -92,7 +92,9 @@ const GUID kChromeTraceProviderName = {
// silenced. To record a new error, pass the log string associated
// with that error in the str parameter.
MSVC_DISABLE_OPTIMIZE();
-void SilentRuntimeAssertHandler(const std::string& str) {
+void SilentRuntimeAssertHandler(
+ const char* file, int line, size_t message_start,
+ size_t stack_start, const std::string& str) {
base::debug::BreakDebugger();
}
MSVC_ENABLE_OPTIMIZE();
@@ -103,7 +105,7 @@ void SuppressDialogs() {
if (dialogs_are_suppressed_)
return;
- logging::SetLogAssertHandler(SilentRuntimeAssertHandler);
+ logging::SetLogAssertHandler(base::Bind(SilentRuntimeAssertHandler));
#if defined(OS_WIN)
UINT new_flags = SEM_FAILCRITICALERRORS |

Powered by Google App Engine
This is Rietveld 408576698