Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3468)

Unified Diff: base/test/gtest_xml_unittest_result_printer.cc

Issue 2638763004: Report CHECK/DCHECK to test launcher summary output. (Closed)
Patch Set: Add comment. Fix missed usage of SetLogAssertHandler. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/test/gtest_xml_unittest_result_printer.cc
diff --git a/base/test/gtest_xml_unittest_result_printer.cc b/base/test/gtest_xml_unittest_result_printer.cc
index 6ce4fdecf3fcddd2487f5e529e56f86d00f1a2e3..18a2cb95309c64521fe3bf290a87dd0b8338eb5a 100644
--- a/base/test/gtest_xml_unittest_result_printer.cc
+++ b/base/test/gtest_xml_unittest_result_printer.cc
@@ -35,6 +35,26 @@ bool XmlUnitTestResultPrinter::Initialize(const FilePath& output_file_path) {
return true;
}
+void XmlUnitTestResultPrinter::OnAssert(const char* file,
+ int line,
+ const std::string& summary,
+ const std::string& message) {
+ if (output_file_) {
Paweł Hajdan Jr. 2017/01/27 17:19:44 nit: Please reverse condition, do early return, an
alex-ac 2017/02/11 20:12:19 Done.
+ std::string encoded_summary;
+ Base64Encode(summary, &encoded_summary);
+ std::string encoded_message;
+ Base64Encode(message, &encoded_message);
+ fprintf(output_file_,
+ " <x-test-result-part type=\"fatal_failure\" "
+ "file=\"%s\" line=\"%d\">\n"
+ " <summary>%s</summary>\n"
+ " <message>%s</message>\n"
+ " </x-test-result-part>",
+ file, line, encoded_summary.c_str(), encoded_message.c_str());
+ fflush(output_file_);
+ }
+}
+
void XmlUnitTestResultPrinter::OnTestCaseStart(
const testing::TestCase& test_case) {
fprintf(output_file_, " <testsuite>\n");

Powered by Google App Engine
This is Rietveld 408576698