Report CHECK/DCHECK to test launcher summary output.

base/test/test_suite.cc

Index: base/test/test_suite.cc
diff --git a/base/test/test_suite.cc b/base/test/test_suite.cc
index 6f4cc372cb86ad73f9388740e5a9f0c05652cc88..47713b4f84d2735e6a51370fc1b9a933202303a0 100644
--- a/base/test/test_suite.cc
+++ b/base/test/test_suite.cc
@@ -238,11 +238,11 @@ void TestSuite::AddTestLauncherResultPrinter() {
     return;
   }
 
-  XmlUnitTestResultPrinter* printer = new XmlUnitTestResultPrinter;
-  CHECK(printer->Initialize(output_path));
+  printer_ = new XmlUnitTestResultPrinter;
+  CHECK(printer_->Initialize(output_path));
   testing::TestEventListeners& listeners =
       testing::UnitTest::GetInstance()->listeners();
-  listeners.Append(printer);
+  listeners.Append(printer_);
 }
 
 // Don't add additional code to this method.  Instead add it to
@@ -283,7 +283,10 @@ int TestSuite::Run() {
 }
 
 // static
-void TestSuite::UnitTestAssertHandler(const std::string& str) {
+void TestSuite::UnitTestAssertHandler(const char* file,
+                                      int line,
+                                      const std::string& summary,
+                                      const std::string& stack_trace) {
 #if defined(OS_ANDROID)
   // Correlating test stdio with logcat can be difficult, so we emit this
   // helpful little hint about what was running.  Only do this for Android
@@ -298,6 +301,8 @@ void TestSuite::UnitTestAssertHandler(const std::string& str) {
   }
 #endif  // defined(OS_ANDROID)
 
+  printer_->OnAssert(file, line, summary, summary + stack_trace);

[Paweł Hajdan Jr., 2017/02/13 17:17:24]

Why do we pass "summary + stack_trace" instead of just stack_trace?

[alex-ac, 2017/02/14 10:34:28]

XmlUnitTestResultPrinter inherits gtest format, where assert has summary and
message. In GTest, summary is just a logged text, and message is a logged text,
concatenated with stack trace of assert. I think it's better to use same format
for DCHECK/CHECK.

[Paweł Hajdan Jr., 2017/02/14 19:23:26]

Okay. Since this is not obvious, could you add a comment to the code?

[alex-ac, 2017/03/09 14:15:52]

Done.

+
   // The logging system actually prints the message before calling the assert
   // handler. Just exit now to avoid printing too many stack traces.
   _exit(1);
@@ -359,7 +364,8 @@ void TestSuite::Initialize() {
       !CommandLine::ForCurrentProcess()->HasSwitch("show-error-dialogs")) {
     SuppressErrorDialogs();
     debug::SetSuppressDebugUI(true);
-    logging::SetLogAssertHandler(UnitTestAssertHandler);
+    assert_handler_ = logging::ScopedLogAssertHandler(
+        base::Bind(&TestSuite::UnitTestAssertHandler, base::Unretained(this)));
   }
 
   base::test::InitializeICUForTesting();