Report CHECK/DCHECK to test launcher summary output.

base/test/gtest_xml_unittest_result_printer.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/test/gtest_xml_unittest_result_printer.h"
 
 #include "base/base64.h"
 #include "base/files/file_util.h"
 #include "base/logging.h"
 #include "base/time/time.h"
@@ skipping 17 matching lines @@
   if (!output_file_)
     return false;
 
   fprintf(output_file_,
           "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<testsuites>\n");
   fflush(output_file_);
 
   return true;
 }
 
+void XmlUnitTestResultPrinter::OnAssert(const char* file,
+                                        int line,
+                                        const std::string& summary,
+                                        const std::string& message) {
+  if (!output_file_)

[brettw, 2017/04/17 22:20:34]

This function seems to duplicate WriteTestPartResult for the most part. Is it
possible to de-dupe by either creating a TestPartResult here and calling the
other one, or having them both call a helper that takes everything as arguments?

[alex-ac, 2017/04/18 06:34:21]

Done.

+    return;
+
+  std::string encoded_summary;
+  Base64Encode(summary, &encoded_summary);
+  std::string encoded_message;
+  Base64Encode(message, &encoded_message);
+  fprintf(output_file_,
+          "    <x-test-result-part type=\"fatal_failure\" "
+          "file=\"%s\" line=\"%d\">\n"
+          "      <summary>%s</summary>\n"
+          "      <message>%s</message>\n"
+          "    </x-test-result-part>",
+          file, line, encoded_summary.c_str(), encoded_message.c_str());
+  fflush(output_file_);
+}
+
 void XmlUnitTestResultPrinter::OnTestCaseStart(
     const testing::TestCase& test_case) {
   fprintf(output_file_, "  <testsuite>\n");
   fflush(output_file_);
 }
 
 void XmlUnitTestResultPrinter::OnTestStart(
     const testing::TestInfo& test_info) {
   // This is our custom extension - it helps to recognize which test was
   // running when the test binary crashed. Note that we cannot even open the
@@ skipping 54 matching lines @@
           "      <x-test-result-part type=\"%s\" file=\"%s\" line=\"%d\">\n"
           "        <summary>%s</summary>\n"
           "        <message>%s</message>\n"
           "      </x-test-result-part>\n",
           type, test_part_result.file_name(), test_part_result.line_number(),
           summary_encoded.c_str(), message_encoded.c_str());
   fflush(output_file_);
 }
 
 }  // namespace base