Report CHECK/DCHECK to test launcher summary output.

base/logging.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 
 #include <limits.h>
 #include <stdint.h>
 
+#include "base/callback.h"
 #include "base/debug/activity_tracker.h"
 #include "base/macros.h"
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <io.h>
 typedef HANDLE FileHandle;
 typedef HANDLE MutexHandle;
 // Windows warns on using write().  It prefers _write().
 #define write(fd, buf, count) _write(fd, buf, static_cast<unsigned int>(count))
@@ skipping 94 matching lines @@
 // What should be prepended to each message?
 bool g_log_process_id = false;
 bool g_log_thread_id = false;
 bool g_log_timestamp = true;
 bool g_log_tickcount = false;
 
 // Should we pop up fatal debug messages in a dialog?
 bool show_error_dialogs = false;
 
 // An assert handler override specified by the client to be called instead of
-// the debug message dialog and process termination.
-LogAssertHandlerFunction log_assert_handler = nullptr;
+// the debug message dialog and process termination. Assert handlers are stored
+// in stack to allow overriding and restoring.
+struct LogAssertHandlerStackItem {
+  LogAssertHandlerStackItem* next;
+  LogAssertHandlerFunction handler;
+};

[dcheng, 2017/02/14 23:59:26]

Perhaps just use something from STL here? We can just leak it, but we shouldn't
be writing manual new / delete cleanup code.

My other concern is that because we have a manual push, it's possible to get
unpaired push and pops. Is there any way that we can make the logging handler
always scoped?

[alex-ac, 2017/03/09 14:15:53]

We can't use non-pod type for a global variable. It will not be destructed. So
we have to use new/delete here.

I found unpaired push/pop calls in the chrome/common/logging_chrome.cc, It's
used from the chromeos code to suppress default assert handler until end of the
process lifetime.

[dcheng, 2017/03/09 19:41:02]

It could just be a vector in a LazyInstance/function-local static.

I'd be OK with exposing a push-only API for the CrOS case.

+
+LogAssertHandlerStackItem* log_assert_handler_stack = nullptr;
+
 // A log message handler that gets notified of every log message we process.
 LogMessageHandlerFunction log_message_handler = nullptr;
 
 // Helper functions to wrap platform differences.
 
 int32_t CurrentProcessId() {
 #if defined(OS_WIN)
   return GetCurrentProcessId();
 #elif defined(OS_POSIX)
   return getpid();
@@ skipping 301 matching lines @@
   g_log_process_id = enable_process_id;
   g_log_thread_id = enable_thread_id;
   g_log_timestamp = enable_timestamp;
   g_log_tickcount = enable_tickcount;
 }
 
 void SetShowErrorDialogs(bool enable_dialogs) {
   show_error_dialogs = enable_dialogs;
 }
 
-void SetLogAssertHandler(LogAssertHandlerFunction handler) {
-  log_assert_handler = handler;
+void PushLogAssertHandler(LogAssertHandlerFunction handler) {
+  LogAssertHandlerStackItem* stack_item = new LogAssertHandlerStackItem;
+  stack_item->handler = handler;
+  stack_item->next = log_assert_handler_stack;
+  log_assert_handler_stack = stack_item;
+}
+
+void PopLogAssertHandler() {
+  LogAssertHandlerStackItem* stack_item = log_assert_handler_stack;
+  if (stack_item) {
+    log_assert_handler_stack = stack_item->next;
+    delete stack_item;
+  }
+}
+
+LogAssertHandlerFunction GetLogAssertHandler() {
+  if (log_assert_handler_stack)
+    return log_assert_handler_stack->handler;
+  return LogAssertHandlerFunction();
 }
 
 void SetLogMessageHandler(LogMessageHandlerFunction handler) {
   log_message_handler = handler;
 }
 
 LogMessageHandlerFunction GetLogMessageHandler() {
   return log_message_handler;
 }
 
@@ skipping 65 matching lines @@
 
 LogMessage::LogMessage(const char* file, int line, LogSeverity severity,
                        std::string* result)
     : severity_(severity), file_(file), line_(line) {
   Init(file, line);
   stream_ << "Check failed: " << *result;
   delete result;
 }
 
 LogMessage::~LogMessage() {
+  size_t stack_start = stream_.str().length();
 #if !defined(OFFICIAL_BUILD) && !defined(OS_NACL) && !defined(__UCLIBC__)
   if (severity_ == LOG_FATAL && !base::debug::BeingDebugged()) {
     // Include a stack trace on a fatal, unless a debugger is attached.
     base::debug::StackTrace trace;
     stream_ << std::endl;  // Newline to separate from log message.
     trace.OutputToStream(&stream_);
   }
 #endif
   stream_ << std::endl;
   std::string str_newline(stream_.str());
@@ skipping 188 matching lines @@
         base::debug::GlobalActivityTracker::Get();
     if (tracker)
       tracker->RecordLogMessage(str_newline);
 
     // Ensure the first characters of the string are on the stack so they
     // are contained in minidumps for diagnostic purposes.
     char str_stack[1024];
     str_newline.copy(str_stack, arraysize(str_stack));
     base::debug::Alias(str_stack);
 
+    LogAssertHandlerFunction log_assert_handler = GetLogAssertHandler();
     if (log_assert_handler) {
-      // Make a copy of the string for the handler out of paranoia.
-      log_assert_handler(std::string(stream_.str()));
+      const std::string& full_message = stream_.str();
+      log_assert_handler.Run(
+          file_, line_,
+          full_message.substr(message_start_, stack_start - message_start_),
+          full_message.substr(stack_start));
     } else {
       // Don't use the string with the newline, get a fresh version to send to
       // the debug message process. We also don't display assertions to the
       // user in release mode. The enduser can't do anything with this
       // information, and displaying message boxes when the application is
       // hosed can cause additional problems.
 #ifndef NDEBUG
       if (!base::debug::BeingDebugged()) {
         // Displaying a dialog is unnecessary when debugging and can complicate
         // debugging.
@@ skipping 192 matching lines @@
 BASE_EXPORT void LogErrorNotReached(const char* file, int line) {
   LogMessage(file, line, LOG_ERROR).stream()
       << "NOTREACHED() hit.";
 }
 
 }  // namespace logging
 
 std::ostream& std::operator<<(std::ostream& out, const wchar_t* wstr) {
   return out << (wstr ? base::WideToUTF8(wstr) : std::string());
 }