Report CHECK/DCHECK to test launcher summary output.

base/test/logging_utils.h

+// Copyright (c) 2017 The Chromium Authors. All rights reserved.

[Paweł Hajdan Jr., 2017/02/13 17:17:24]

nit: No (c)

[alex-ac, 2017/02/14 10:34:28]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BASE_TEST_LOGGING_UTILS_H_
+#define BASE_TEST_LOGGING_UTILS_H_
+
+#include "base/base_export.h"
+#include "base/callback.h"
+#include "base/logging.h"
+#include "base/macros.h"
+
+namespace logging {
+
+// Scoped object to set and restore Log Assert handler.
+BASE_EXPORT class ScopedLogAssertHandler {
+ public:
+  ScopedLogAssertHandler();

[Paweł Hajdan Jr., 2017/02/13 17:17:24]

Why do we need default ctor?

[alex-ac, 2017/02/14 10:34:28]

It allows to use this object as an class variable and initialize it after
execution of the constructor. (see base/test/test_suite.cc, where this object is
initialized in the Initialize method).

[Paweł Hajdan Jr., 2017/02/14 19:23:26]

Why don't we use unique_ptr instead, or some similar solution which does not
require default ctor?

[alex-ac, 2017/03/09 14:15:52]

Done.

+  explicit ScopedLogAssertHandler(LogAssertHandlerFunction handler);
+  ScopedLogAssertHandler(ScopedLogAssertHandler&& other);

[Paweł Hajdan Jr., 2017/02/13 17:17:24]

Why do we need this and operator= ?

[alex-ac, 2017/02/14 10:34:28]

Move-assignment operator allows to initialize default-constructed scoped object.

[Paweł Hajdan Jr., 2017/02/14 19:23:26]

To me it's another reason not to need these additions.

[alex-ac, 2017/03/09 14:15:52]

Done.

+  ~ScopedLogAssertHandler();
+
+  ScopedLogAssertHandler& operator=(ScopedLogAssertHandler&& other);
+
+ private:
+  LogAssertHandlerFunction handler_;
+
+  DISALLOW_COPY_AND_ASSIGN(ScopedLogAssertHandler);
+};
+
+}  // namespace logging
+
+#endif  // BASE_TEST_LOGGING_UTILS_H_