Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

Issue 2638623003: Media Controls: invalidate volume slider when value changes. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
index ab7ea8ba8e3b49eb06eab6803c62fa301c017a3f..22fb23c994c4be23658f73e44880d9b9c80ace6e 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
@@ -856,8 +856,12 @@ bool MediaControlVolumeSliderElement::willRespondToMouseClickEvents() {
}
void MediaControlVolumeSliderElement::setVolume(double volume) {
- if (value().toDouble() != volume)
- setValue(String::number(volume));
+ if (value().toDouble() == volume)
+ return;
+
+ setValue(String::number(volume));
+ if (LayoutObject* layoutObject = this->layoutObject())
+ layoutObject->setShouldDoFullPaintInvalidation();
}
bool MediaControlVolumeSliderElement::keepEventInNode(Event* event) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698