Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2196)

Unified Diff: Source/web/tests/PinchViewportTest.cpp

Issue 263853008: Added pinch viewport offset to history item. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added backward compatibility, tests Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/tests/PinchViewportTest.cpp
diff --git a/Source/web/tests/PinchViewportTest.cpp b/Source/web/tests/PinchViewportTest.cpp
index f1e6dbf93f491baf8625b21603e2f3adbac1e6ed..969e95917484dbba3e38c2b35b5347d8ac356134 100644
--- a/Source/web/tests/PinchViewportTest.cpp
+++ b/Source/web/tests/PinchViewportTest.cpp
@@ -22,6 +22,12 @@
#include <gmock/gmock.h>
#include <gtest/gtest.h>
+#define EXPECT_POINT_EQ(expected, actual) \
+ do { \
+ EXPECT_EQ((expected).x(), (actual).x()); \
+ EXPECT_EQ((expected).y(), (actual).y()); \
+ } while (false)
+
#define EXPECT_FLOAT_POINT_EQ(expected, actual) \
do { \
EXPECT_FLOAT_EQ((expected).x(), (actual).x()); \
@@ -430,4 +436,80 @@ TEST_F(PinchViewportTest, TestPinchViewportGetsSizeInAutoSizeMode)
EXPECT_SIZE_EQ(IntSize(200, 300), frame()->page()->frameHost().pinchViewport().size());
}
+// Test that the HistoryItem for the page stores the pinch viewport's offset and scale.
+TEST_F(PinchViewportTest, TestSavedToHistoryItem)
+{
+ initializeWithDesktopSettings();
+ webViewImpl()->resize(IntSize(200, 300));
+ webViewImpl()->layout();
+
+ registerMockedHttpURLLoad("200-by-300.html");
+ navigateTo(m_baseURL + "200-by-300.html");
+
+ EXPECT_FLOAT_POINT_EQ(FloatPoint(0, 0),
+ webViewImpl()->page()->mainFrame()->loader().currentItem()->pinchViewportScrollPoint());
+
+ PinchViewport& pinchViewport = frame()->page()->frameHost().pinchViewport();
+ pinchViewport.setScale(2);
+
+ EXPECT_EQ(2, webViewImpl()->page()->mainFrame()->loader().currentItem()->pageScaleFactor());
+
+ pinchViewport.setLocation(FloatPoint(10, 20));
+
+ EXPECT_FLOAT_POINT_EQ(FloatPoint(10, 20),
+ webViewImpl()->page()->mainFrame()->loader().currentItem()->pinchViewportScrollPoint());
+}
+
+// Test restoring a HistoryItem properly restores the pinch viewport's state.
+TEST_F(PinchViewportTest, TestRestoredFromHistoryItem)
+{
+ initializeWithDesktopSettings();
+ webViewImpl()->resize(IntSize(200, 300));
+
+ registerMockedHttpURLLoad("200-by-300.html");
+
+ WebHistoryItem item;
+ item.initialize();
+ WebURL destinationURL(blink::URLTestHelpers::toKURL(m_baseURL + "200-by-300.html"));
+ item.setURLString(destinationURL.string());
+ item.setPinchViewportScrollOffset(WebFloatPoint(100, 120));
+ item.setPageScaleFactor(2);
+
+ webViewImpl()->mainFrame()->loadHistoryItem(item, WebHistoryDifferentDocumentLoad, WebURLRequest::UseProtocolCachePolicy);
+ Platform::current()->unitTestSupport()->serveAsynchronousMockedRequests();
+
+ PinchViewport& pinchViewport = frame()->page()->frameHost().pinchViewport();
+ EXPECT_EQ(2, pinchViewport.scale());
+
+ EXPECT_FLOAT_POINT_EQ(FloatPoint(100, 120), pinchViewport.visibleRect().location());
+}
+
+// Test restoring a HistoryItem without the pinch viewport offset falls back to distributing
+// the scroll offset between the main frame and the pinch viewport.
+TEST_F(PinchViewportTest, TestRestoredFromLegacyHistoryItem)
+{
+ initializeWithDesktopSettings();
+ webViewImpl()->resize(IntSize(100, 150));
+
+ registerMockedHttpURLLoad("200-by-300-viewport.html");
+
+ WebHistoryItem item;
+ item.initialize();
+ WebURL destinationURL(blink::URLTestHelpers::toKURL(m_baseURL + "200-by-300-viewport.html"));
+ item.setURLString(destinationURL.string());
+ // (-1, -1) will be used if the HistoryItem is an older version prior to having
+ // pinch viewport scroll offset.
+ item.setPinchViewportScrollOffset(WebFloatPoint(-1, -1));
+ item.setScrollOffset(WebPoint(120, 180));
+ item.setPageScaleFactor(2);
+
+ webViewImpl()->mainFrame()->loadHistoryItem(item, WebHistoryDifferentDocumentLoad, WebURLRequest::UseProtocolCachePolicy);
+ Platform::current()->unitTestSupport()->serveAsynchronousMockedRequests();
+
+ PinchViewport& pinchViewport = frame()->page()->frameHost().pinchViewport();
+ EXPECT_EQ(2, pinchViewport.scale());
+ EXPECT_POINT_EQ(IntPoint(100, 150), frame()->view()->scrollPosition());
+ EXPECT_FLOAT_POINT_EQ(FloatPoint(20, 30), pinchViewport.visibleRect().location());
+}
+
} // namespace

Powered by Google App Engine
This is Rietveld 408576698