Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 263853004: Add checkerboard under the image. (Closed)

Created:
6 years, 7 months ago by jcgregorio
Modified:
6 years, 7 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add checkerboard under the image. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14519

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rerebase #

Patch Set 4 : use a data uri #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M experimental/webtry/res/css/webtry.css View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
jcgregorio
6 years, 7 months ago (2014-05-01 19:04:23 UTC) #1
mtklein
lgtm
6 years, 7 months ago (2014-05-01 20:15:24 UTC) #2
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 7 months ago (2014-05-01 20:19:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/263853004/1
6 years, 7 months ago (2014-05-01 20:19:41 UTC) #4
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 7 months ago (2014-05-01 20:27:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/263853004/20001
6 years, 7 months ago (2014-05-01 20:28:12 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 20:28:19 UTC) #7
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
6 years, 7 months ago (2014-05-01 20:28:19 UTC) #8
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 7 months ago (2014-05-01 20:30:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/263853004/40001
6 years, 7 months ago (2014-05-01 20:30:44 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 20:37:04 UTC) #11
commit-bot: I haz the power
Retried try job too often on Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot for step(s) BuildBench, BuildEverything, BuildGm, BuildSkiaLib, BuildTests, BuildTools ...
6 years, 7 months ago (2014-05-01 20:37:04 UTC) #12
jcgregorio
On 2014/05/01 20:37:04, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 7 months ago (2014-05-01 20:43:19 UTC) #13
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 7 months ago (2014-05-01 20:43:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/263853004/50001
6 years, 7 months ago (2014-05-01 20:43:40 UTC) #15
commit-bot: I haz the power
6 years, 7 months ago (2014-05-01 20:52:14 UTC) #16
Message was sent while issue was closed. 
Change committed as 14519

Powered by Google App Engine
This is Rietveld 408576698