Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2638463002: Remaining parser changes for generic function types (Closed)

Created:
3 years, 11 months ago by Brian Wilkerson
Modified:
3 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+391 lines, -85 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 36 chunks +174 lines, -62 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 23 chunks +217 lines, -23 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
I believe this allows the generic function type syntax everywhere else that it should be ...
3 years, 11 months ago (2017-01-13 22:46:13 UTC) #2
scheglov
LGTM
3 years, 11 months ago (2017-01-13 23:45:29 UTC) #3
Brian Wilkerson
3 years, 11 months ago (2017-01-14 16:23:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bdb36c9c695b99afe62039688fd2abf3d9362625 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698