components/favicon/content/content_favicon_driver.h - Issue 2638423008: Convert ContentFaviconDriver to use the new navigation callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/content/content_favicon_driver.h

Issue 2638423008: Convert ContentFaviconDriver to use the new navigation callbacks. (Closed)

Patch Set: fix test by only looking at successful commits as before Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon/content/content_favicon_driver.h

diff --git a/components/favicon/content/content_favicon_driver.h b/components/favicon/content/content_favicon_driver.h

index 76af5eed5aa36a95301e9b6c5ca542c603627bab..75f5dbee954a68fab735256ecd4f055877038fb8 100644

--- a/components/favicon/content/content_favicon_driver.h

+++ b/components/favicon/content/content_favicon_driver.h

@@ -70,12 +70,10 @@ class ContentFaviconDriver

// content::WebContentsObserver implementation.

void DidUpdateFaviconURL(

const std::vector<content::FaviconURL>& candidates) override;

- void DidStartNavigationToPendingEntry(

- const GURL& url,

- content::ReloadType reload_type) override;

- void DidNavigateMainFrame(

- const content::LoadCommittedDetails& details,

- const content::FrameNavigateParams& params) override;

+ void DidStartNavigation(

+ content::NavigationHandle* navigation_handle) override;

+ void DidFinishNavigation(

+ content::NavigationHandle* navigation_handle) override;

GURL bypass_cache_page_url_;

std::vector<content::FaviconURL> favicon_urls_;