Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: components/favicon/content/content_favicon_driver.h

Issue 2638423008: Convert ContentFaviconDriver to use the new navigation callbacks. (Closed)
Patch Set: add comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/favicon/content/content_favicon_driver.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FAVICON_CONTENT_CONTENT_FAVICON_DRIVER_H_ 5 #ifndef COMPONENTS_FAVICON_CONTENT_CONTENT_FAVICON_DRIVER_H_
6 #define COMPONENTS_FAVICON_CONTENT_CONTENT_FAVICON_DRIVER_H_ 6 #define COMPONENTS_FAVICON_CONTENT_CONTENT_FAVICON_DRIVER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "components/favicon/core/favicon_driver_impl.h" 9 #include "components/favicon/core/favicon_driver_impl.h"
10 #include "content/public/browser/reload_type.h" 10 #include "content/public/browser/reload_type.h"
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 void OnFaviconUpdated( 63 void OnFaviconUpdated(
64 const GURL& page_url, 64 const GURL& page_url,
65 FaviconDriverObserver::NotificationIconType icon_type, 65 FaviconDriverObserver::NotificationIconType icon_type,
66 const GURL& icon_url, 66 const GURL& icon_url,
67 bool icon_url_changed, 67 bool icon_url_changed,
68 const gfx::Image& image) override; 68 const gfx::Image& image) override;
69 69
70 // content::WebContentsObserver implementation. 70 // content::WebContentsObserver implementation.
71 void DidUpdateFaviconURL( 71 void DidUpdateFaviconURL(
72 const std::vector<content::FaviconURL>& candidates) override; 72 const std::vector<content::FaviconURL>& candidates) override;
73 void DidStartNavigationToPendingEntry( 73 void DidStartNavigation(
74 const GURL& url, 74 content::NavigationHandle* navigation_handle) override;
75 content::ReloadType reload_type) override; 75 void DidFinishNavigation(
76 void DidNavigateMainFrame( 76 content::NavigationHandle* navigation_handle) override;
77 const content::LoadCommittedDetails& details,
78 const content::FrameNavigateParams& params) override;
79 77
80 GURL bypass_cache_page_url_; 78 GURL bypass_cache_page_url_;
81 std::vector<content::FaviconURL> favicon_urls_; 79 std::vector<content::FaviconURL> favicon_urls_;
82 80
83 DISALLOW_COPY_AND_ASSIGN(ContentFaviconDriver); 81 DISALLOW_COPY_AND_ASSIGN(ContentFaviconDriver);
84 }; 82 };
85 83
86 } // namespace favicon 84 } // namespace favicon
87 85
88 #endif // COMPONENTS_FAVICON_CONTENT_CONTENT_FAVICON_DRIVER_H_ 86 #endif // COMPONENTS_FAVICON_CONTENT_CONTENT_FAVICON_DRIVER_H_
OLDNEW
« no previous file with comments | « no previous file | components/favicon/content/content_favicon_driver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698