Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2638423005: Make FrameSelection to utilize SynchronousMutationObserver (Closed)
Patch Set: 2017-01-20T19:16:11 Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp
index 12d4d9c61f5f4b1f8977b19a44c0a4ca9a6110d8..e8079d637be1ec5f34f1d7219b3b7c4056aa33cc 100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -2488,7 +2488,6 @@ void Document::shutdown() {
// Signal destruction to mutation observers.
SynchronousMutationNotifier::notifyContextDestroyed();
- m_frame->selection().documentDetached(*this);
// If this Document is associated with a live DocumentLoader, the
// DocumentLoader will take care of clearing the FetchContext. Deferring
@@ -4217,8 +4216,6 @@ void Document::nodeChildrenWillBeRemoved(ContainerNode& container) {
}
notifyNodeChildrenWillBeRemoved(container);
- if (LocalFrame* frame = this->frame())
- frame->selection().nodeChildrenWillBeRemoved(container);
if (containsV1ShadowTree()) {
for (Node& n : NodeTraversal::childrenOf(container))
@@ -4235,10 +4232,6 @@ void Document::nodeWillBeRemoved(Node& n) {
notifyNodeWillBeRemoved(n);
- if (LocalFrame* frame = this->frame()) {
- frame->selection().nodeWillBeRemoved(n);
- }
-
if (containsV1ShadowTree())
n.checkSlotChangeBeforeRemoved();
@@ -4276,8 +4269,6 @@ void Document::didMergeTextNodes(const Text& mergedNode,
}
notifyMergeTextNodes(mergedNode, nodeToBeRemovedWithIndex, oldLength);
- if (m_frame)
- m_frame->selection().didMergeTextNodes(nodeToBeRemoved, oldLength);
// FIXME: This should update markers for spelling and grammar checking.
}
@@ -4287,8 +4278,6 @@ void Document::didSplitTextNode(const Text& oldNode) {
range->didSplitTextNode(oldNode);
notifySplitTextNode(oldNode);
- if (m_frame)
- m_frame->selection().didSplitTextNode(oldNode);
// FIXME: This should update markers for spelling and grammar checking.
}
« no previous file with comments | « third_party/WebKit/Source/core/dom/CharacterData.cpp ('k') | third_party/WebKit/Source/core/editing/FrameSelection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698