Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 2638423002: Fix incremental kernel builder to handle multiple calls to computeDelta. (Closed)

Created:
3 years, 11 months ago by Paul Berry
Modified:
3 years, 11 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix incremental kernel builder to handle multiple calls to computeDelta. Note that the invalidate() method is not supported yet; you must use invalidateAll(). R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/2adae270d6219a40af5400440a15be73de952b12

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -26 lines) Patch
M pkg/front_end/lib/src/incremental_resolved_ast_generator_impl.dart View 4 chunks +12 lines, -4 lines 0 comments Download
M pkg/front_end/test/incremental_kernel_generator_test.dart View 3 chunks +56 lines, -13 lines 0 comments Download
M pkg/front_end/test/incremental_resolved_ast_generator_test.dart View 2 chunks +53 lines, -9 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 11 months ago (2017-01-18 14:59:31 UTC) #2
danrubel
LGTM https://codereview.chromium.org/2638423002/diff/1/pkg/front_end/test/incremental_resolved_ast_generator_test.dart File pkg/front_end/test/incremental_resolved_ast_generator_test.dart (right): https://codereview.chromium.org/2638423002/diff/1/pkg/front_end/test/incremental_resolved_ast_generator_test.dart#newcode64 pkg/front_end/test/incremental_resolved_ast_generator_test.dart:64: void _checkMain(CompilationUnit unit, int expectedArgument) { nit: blank ...
3 years, 11 months ago (2017-01-18 20:47:36 UTC) #3
Paul Berry
https://codereview.chromium.org/2638423002/diff/1/pkg/front_end/test/incremental_resolved_ast_generator_test.dart File pkg/front_end/test/incremental_resolved_ast_generator_test.dart (right): https://codereview.chromium.org/2638423002/diff/1/pkg/front_end/test/incremental_resolved_ast_generator_test.dart#newcode64 pkg/front_end/test/incremental_resolved_ast_generator_test.dart:64: void _checkMain(CompilationUnit unit, int expectedArgument) { On 2017/01/18 20:47:36, ...
3 years, 11 months ago (2017-01-18 22:36:31 UTC) #4
Paul Berry
3 years, 11 months ago (2017-01-18 22:43:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2adae270d6219a40af5400440a15be73de952b12 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698