ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h - Issue 2638413006: Add ContentSuggestionsMediator

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h

Issue 2638413006: Add ContentSuggestionsMediator (Closed)

Patch Set: Fix Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/chrome/browser/ui/content_suggestions/content_suggestions_data.h ('K') | « ios/chrome/browser/ui/content_suggestions/content_suggestions_data.h ('k') | ios/chrome/browser/ui/content_suggestions/content_suggestions_data_source.h » ('j') | ios/chrome/browser/ui/content_suggestions/content_suggestions_data_source.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTIONS_DATA_SINK_ H_

	6 #define IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTIONS_DATA_SINK_ H_

	7

	8 // Data sink for the ContentSuggestions. It will be notified when new data need

	9 // to be pulled.

	10 @protocol ContentSuggestionsDataSink

	11

	12 // Notifies the Data Sink that new data are available.
	marq (ping after 24h) 2017/01/27 12:44:55 Super nit: 'data' is the plural of the singular 'd Super nit: 'data' is the plural of the singular 'datum', but it is usually treated like a grammatically singular mass noun (like 'water', 'dust', 'food'). So: 'new data is available'. gambard 2017/01/30 15:19:17 Oh. Ok, I always treated it as plural. Show quoted text On 2017/01/27 12:44:55, marq wrote: > Super nit: 'data' is the plural of the singular 'datum', but it is usually > treated like a grammatically singular mass noun (like 'water', 'dust', 'food'). > So: 'new data is available'. Oh. Ok, I always treated it as plural.
	13 - (void)dataAvailable;
	marq (ping after 24h) 2017/01/27 12:44:55 This is interesting to consider and I don't have a This is interesting to consider and I don't have any concrete answers yet -- but should this protocol push the data, or just alert the sink and let it pull via the DataSource protocol? No change needed, but something to consider as this evolves. gambard 2017/01/30 15:19:17 By your own documentation: "The dataSource pattern Show quoted text On 2017/01/27 12:44:55, marq wrote: > This is interesting to consider and I don't have any concrete answers yet -- but > should this protocol push the data, or just alert the sink and let it pull via > the DataSource protocol? No change needed, but something to consider as this > evolves. By your own documentation: "The dataSource pattern is pull, not push." :) I will see how it evolves.
	14

	15 @end

	16

	17 #endif // IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTIONS_DATA_SI NK_H_

OLD	NEW