ios/chrome/browser/ui/content_suggestions/content_suggestions_data.h - Issue 2638413006: Add ContentSuggestionsMediator

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/ui/content_suggestions/content_suggestions_data.h

Issue 2638413006: Add ContentSuggestionsMediator (Closed)

Patch Set: Fix Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm ('K') | « ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm ('k') | ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h » ('j') | ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTIONS_DATA_H_

	6 #define IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTIONS_DATA_H_

	7

	8 #import <UIkit/UIKit.h>

	9

	10 // Protocol to give data to the UI of the ContentSuggestions.

	11 @protocol ContentSuggestionsData
	marq (ping after 24h) 2017/01/27 12:44:55 Avoid very general words in name like 'Data', "Val Avoid very general words in name like 'Data', "Value', 'Object', 'Result'. This sounds like it can just be a 'ContentSuggestion', maybe? gambard 2017/01/30 15:19:17 Done. Show quoted text On 2017/01/27 12:44:55, marq wrote: > Avoid very general words in name like 'Data', "Value', 'Object', 'Result'. This > sounds like it can just be a 'ContentSuggestion', maybe? Done.
	12
	marq (ping after 24h) 2017/01/27 12:44:55 I'm also not sure about the merits of defining dat I'm also not sure about the merits of defining data containers like this with protocols. A superclass seems fine as long as it remains unencumbered by dependencies. Protocols are great for defining interfaces with behavior behind them, but they are limited in how we can type-check them, and -conformsToProtocol can actually have performance issues in some cases. So maybe it's better to just use a class here. gambard 2017/01/30 15:19:17 I will use the class directly for now. If it cause Show quoted text On 2017/01/27 12:44:55, marq wrote: > I'm also not sure about the merits of defining data containers like this with > protocols. A superclass seems fine as long as it remains unencumbered by > dependencies. > > Protocols are great for defining interfaces with behavior behind them, but they > are limited in how we can type-check them, and -conformsToProtocol can actually > have performance issues in some cases. So maybe it's better to just use a > class here. I will use the class directly for now. If it causes trouble I will revert back to protocol.
	13 @property(nonatomic, readonly, copy) NSString* title;

	14 @property(nonatomic, readonly, strong) UIImage* image;

	15

	16 @end

	17

	18 #endif // IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CONTENT_SUGGESTIONS_DATA_H_

OLD	NEW