Add ContentSuggestionsMediator

ios/chrome/browser/content_suggestions/content_suggestions_service_bridge_observer.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_CHROME_BROWSER_CONTENT_SUGGESTIONS_CONTENT_SUGGESTIONS_SERVICE_BRIDGE_OBSERVER_H_
+#define IOS_CHROME_BROWSER_CONTENT_SUGGESTIONS_CONTENT_SUGGESTIONS_SERVICE_BRIDGE_OBSERVER_H_
+
+#include "components/ntp_snippets/content_suggestions_service.h"
+
+// Protocol duplicating all ContentSuggestionsService Observer methods in
+// Objective-C.
+@protocol ContentSuggestionsServiceBridgeObserver

[marq (ping after 24h), 2017/01/27 12:44:55]

Remove 'Bridge" from the protocol name.

[gambard, 2017/01/30 15:19:17]

Done.

+

[marq (ping after 24h), 2017/01/27 12:44:55]

You still need comments for each method declaration; compare to
web_state_observer_bridge.h

[gambard, 2017/01/30 15:19:17]

Done.

+- (void)onNewSuggestions:(ntp_snippets::Category)category;

[marq (ping after 24h), 2017/01/27 12:44:55]

The usual pattern for delegate and observer protocols is to pass the delegating
or observed object as the first parameter, so I would expect to see the
ContentSuggestionsService object in each of these methods.

[gambard, 2017/01/30 15:19:17]

Done.

+- (void)onCategory:(ntp_snippets::Category)category
+     statusChanged:(ntp_snippets::CategoryStatus)status;
+- (void)onSuggestionInvalidated:
+    (const ntp_snippets::ContentSuggestion::ID&)suggestion_id;
+- (void)onFullRefreshRequired;
+- (void)contentSuggestionsServiceShutdown;
+
+@end
+
+// Observer for the ContentSuggestionsService that translates all the callbacks
+// to Objective-C calls.
+class ContentSuggestionsServiceBridge
+    : public ntp_snippets::ContentSuggestionsService::Observer {
+ public:
+  ContentSuggestionsServiceBridge(
+      id<ContentSuggestionsServiceBridgeObserver> observer,
+      ntp_snippets::ContentSuggestionsService* service);
+  ~ContentSuggestionsServiceBridge() override;
+
+ private:
+  void OnNewSuggestions(ntp_snippets::Category category) override;
+  void OnCategoryStatusChanged(
+      ntp_snippets::Category category,
+      ntp_snippets::CategoryStatus new_status) override;
+  void OnSuggestionInvalidated(
+      const ntp_snippets::ContentSuggestion::ID& suggestion_id) override;
+  void OnFullRefreshRequired() override;
+  void ContentSuggestionsServiceShutdown() override;
+
+  __unsafe_unretained id<ContentSuggestionsServiceBridgeObserver> observer_;
+  ntp_snippets::ContentSuggestionsService* service_;  // weak
+
+  DISALLOW_COPY_AND_ASSIGN(ContentSuggestionsServiceBridge);
+};
+
+#endif  // IOS_CHROME_BROWSER_CONTENT_SUGGESTIONS_CONTENT_SUGGESTIONS_SERVICE_BRIDGE_OBSERVER_H_