Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2638403004: Test for kernel async stacktrace bug (Closed)

Created:
3 years, 11 months ago by jensj
Modified:
3 years, 11 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Changes based on feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -0 lines) Patch
M tests/language/language_kernel.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
A tests/language/vm/async_await_catch_stacktrace_test.dart View 1 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jensj
3 years, 11 months ago (2017-01-19 11:02:19 UTC) #3
kustermann
lgtm, thanks for the test https://codereview.chromium.org/2638403004/diff/1/tests/language/async_await_catch_stacktrace_test.dart File tests/language/async_await_catch_stacktrace_test.dart (right): https://codereview.chromium.org/2638403004/diff/1/tests/language/async_await_catch_stacktrace_test.dart#newcode9 tests/language/async_await_catch_stacktrace_test.dart:9: var x = () ...
3 years, 11 months ago (2017-01-19 11:29:44 UTC) #4
jensj
https://codereview.chromium.org/2638403004/diff/1/tests/language/async_await_catch_stacktrace_test.dart File tests/language/async_await_catch_stacktrace_test.dart (right): https://codereview.chromium.org/2638403004/diff/1/tests/language/async_await_catch_stacktrace_test.dart#newcode9 tests/language/async_await_catch_stacktrace_test.dart:9: var x = () async { On 2017/01/19 11:29:44, ...
3 years, 11 months ago (2017-01-19 11:36:58 UTC) #5
jensj
3 years, 11 months ago (2017-01-19 11:38:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
919b5ac8d0588f74b1bff6d77297f2916752560b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698