Issue 2638393004: Fix subtyping check on number

Issue 2638393004: Fix subtyping check on number (Closed)

Created:
3 years, 11 months ago by vsm

Modified:
3 years, 11 months ago

Reviewers:
Leaf, scheglov

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix subtyping check on number language_strong/null_is_test started failing on Konstantin's recent change. Another test started passing. Does this fix make sense to you guys? TBR=leafp@google.com,scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/5b34e47f406e35cca060f95d0a2f7b48d9216b63

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -2 lines)			Patch
M	pkg/dev_compiler/lib/sdk/ddc_sdk.sum	View	Binary file		0 comments	Download
M	pkg/dev_compiler/lib/src/compiler/code_generator.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/dev_compiler/test/browser/language_tests.js	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 7 (4 generated)

vsm

Committed patchset #1 (id:1) manually as 5b34e47f406e35cca060f95d0a2f7b48d9216b63 (presubmit successful).

3 years, 11 months ago (2017-01-18 21:27:37 UTC) #6

Message was sent while issue was closed.

lgtm