Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1620)

Unified Diff: test/mjsunit/wasm/unreachable-validation.js

Issue 2638383004: [wasm] Fix checking of unreachable code (clear stack after unreachable). (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/wasm/function-body-decoder.cc ('K') | « src/wasm/function-body-decoder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/wasm/unreachable-validation.js
diff --git a/test/mjsunit/wasm/unreachable-validation.js b/test/mjsunit/wasm/unreachable-validation.js
index f62e0cc929fdb6a5098d0cfc81069a342c10bada..773614bb4d092cd00befe8a3f39122d73d301d98 100644
--- a/test/mjsunit/wasm/unreachable-validation.js
+++ b/test/mjsunit/wasm/unreachable-validation.js
@@ -96,9 +96,10 @@ run(I, "(block U) 0f 0 iadd drop", [...block_unr, ...f32, ...zero, iadd, drop]);
run(I, "(loop U) 0f 0 iadd drop", [...loop_unr, ...f32, ...zero, iadd, drop]);
run(I, "(block (block U)) 0f 0 iadd drop", [...block_block_unr, ...f32, ...zero, iadd, drop]);
-// TODO(titzer): these are actually incorrect in V8.
-run(I, "0f U iadd drop", [...f32, unr, iadd, drop]);
-run(I, "0f 0 U iadd drop", [...f32, ...zero, unr, iadd, drop]);
+run(V, "0f U iadd drop", [...f32, unr, iadd, drop]);
+run(V, "0f 0 U iadd drop", [...f32, ...zero, unr, iadd, drop]);
run(I, "0f 0 (block U) iadd drop", [...f32, ...zero, ...block_unr, iadd, drop]);
-run(I, "0f U 0 iadd drop", [...f32, unr, ...zero, iadd, drop]);
+run(V, "0f U 0 iadd drop", [...f32, unr, ...zero, iadd, drop]);
+run(I, "0 U 0f iadd drop", [...zero, unr, ...zero, ...f32, iadd, drop]);
run(I, "0f (block U) 0 iadd drop", [...f32, ...block_unr, ...zero, iadd, drop]);
+run(I, "0 (block U) 0f iadd drop", [...zero, ...block_unr, ...f32, iadd, drop]);
« src/wasm/function-body-decoder.cc ('K') | « src/wasm/function-body-decoder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698