Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Unified Diff: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp

Issue 2638333007: Add compositor element id for scroll nodes in SPv2. (Closed)
Patch Set: Sync to head. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
index da7f176c635bffc077ea634a1f69752921de5cea..c58bcde33d42102ce96836d6dd5809f1da515d7d 100644
--- a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
+++ b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
@@ -96,6 +96,13 @@ class PaintArtifactCompositorTestWithPropertyTrees
->property_trees();
}
+ int elementIdToScrollNodeIndex(CompositorElementId elementId) {
+ return m_webLayerTreeView->layerTreeHost()
+ ->GetLayerTree()
+ ->property_trees()
+ ->element_id_to_scroll_node_index[elementId];
+ }
+
const cc::TransformNode& transformNode(const cc::Layer* layer) {
return *propertyTrees().transform_tree.Node(layer->transform_tree_index());
}
@@ -654,9 +661,11 @@ TEST_F(PaintArtifactCompositorTestWithPropertyTrees, OneScrollNode) {
TransformPaintPropertyNode::create(TransformPaintPropertyNode::root(),
TransformationMatrix().translate(7, 9),
FloatPoint3D());
+ CompositorElementId expectedCompositorElementId = CompositorElementId(2, 0);
RefPtr<ScrollPaintPropertyNode> scroll = ScrollPaintPropertyNode::create(
ScrollPaintPropertyNode::root(), scrollTranslation, IntSize(11, 13),
- IntSize(27, 31), true, false, 0);
+ IntSize(27, 31), true, false, 0 /* mainThreadScrollingReasons */,
+ expectedCompositorElementId);
TestPaintArtifact artifact;
artifact
@@ -674,6 +683,9 @@ TEST_F(PaintArtifactCompositorTestWithPropertyTrees, OneScrollNode) {
EXPECT_TRUE(scrollNode.user_scrollable_horizontal);
EXPECT_FALSE(scrollNode.user_scrollable_vertical);
EXPECT_EQ(1, scrollNode.parent_id);
+ EXPECT_EQ(expectedCompositorElementId, scrollNode.element_id);
+ EXPECT_EQ(scrollNode.id,
+ elementIdToScrollNodeIndex(expectedCompositorElementId));
const cc::TransformTree& transformTree = propertyTrees().transform_tree;
const cc::TransformNode& transformNode =
@@ -691,6 +703,8 @@ TEST_F(PaintArtifactCompositorTestWithPropertyTrees, NestedScrollNodes) {
RefPtr<EffectPaintPropertyNode> effect =
createOpacityOnlyEffect(EffectPaintPropertyNode::root(), 0.5);
+ CompositorElementId expectedCompositorElementIdA = CompositorElementId(2, 0);
+ CompositorElementId expectedCompositorElementIdB = CompositorElementId(3, 0);
RefPtr<TransformPaintPropertyNode> scrollTranslationA =
TransformPaintPropertyNode::create(
TransformPaintPropertyNode::root(),
@@ -698,14 +712,15 @@ TEST_F(PaintArtifactCompositorTestWithPropertyTrees, NestedScrollNodes) {
RefPtr<ScrollPaintPropertyNode> scrollA = ScrollPaintPropertyNode::create(
ScrollPaintPropertyNode::root(), scrollTranslationA, IntSize(2, 3),
IntSize(5, 7), false, true,
- MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects);
+ MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects,
+ expectedCompositorElementIdA);
RefPtr<TransformPaintPropertyNode> scrollTranslationB =
TransformPaintPropertyNode::create(
scrollTranslationA, TransformationMatrix().translate(37, 41),
FloatPoint3D());
RefPtr<ScrollPaintPropertyNode> scrollB = ScrollPaintPropertyNode::create(
scrollA, scrollTranslationB, IntSize(19, 23), IntSize(29, 31), true,
- false, 0);
+ false, 0 /* mainThreadScrollingReasons */, expectedCompositorElementIdB);
TestPaintArtifact artifact;
artifact
.chunk(scrollTranslationA, ClipPaintPropertyNode::root(), effect, scrollA)
@@ -730,6 +745,12 @@ TEST_F(PaintArtifactCompositorTestWithPropertyTrees, NestedScrollNodes) {
EXPECT_TRUE(scrollNodeB.user_scrollable_horizontal);
EXPECT_FALSE(scrollNodeB.user_scrollable_vertical);
EXPECT_EQ(scrollNodeA.id, scrollNodeB.parent_id);
+ EXPECT_EQ(expectedCompositorElementIdA, scrollNodeA.element_id);
+ EXPECT_EQ(scrollNodeA.id,
+ elementIdToScrollNodeIndex(expectedCompositorElementIdA));
+ EXPECT_EQ(expectedCompositorElementIdB, scrollNodeB.element_id);
+ EXPECT_EQ(scrollNodeB.id,
+ elementIdToScrollNodeIndex(expectedCompositorElementIdB));
const cc::TransformTree& transformTree = propertyTrees().transform_tree;
const cc::TransformNode& transformNodeA =

Powered by Google App Engine
This is Rietveld 408576698