Small refactoring for app_search_provider.

Small refactoring in app_search_provider.

If wrong notification is received, NOTREACHED() is called.

BUG=None
R=benwells@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269604

[limasdf, 2014-05-06 14:32:17]

ptal

[benwells, 2014-05-07 00:25:06]

lgtm but please update the description to have more information on what you've
done.

[limasdf, 2014-05-09 07:57:58]

thanks for the review. commit description is updated.

[limasdf, 2014-05-09 07:58:03]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-05-09 08:02:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/limasdf@gmail.com/263833019/1

[commit-bot: I haz the power, 2014-05-09 09:52:44]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-09 11:00:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-09 11:00:31]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[limasdf, 2014-05-09 11:08:52]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-05-09 11:15:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/limasdf@gmail.com/263833019/1

[commit-bot: I haz the power, 2014-05-09 12:50:07]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-09 13:41:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-09 13:41:31]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[limasdf, 2014-05-09 16:20:07]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-05-09 16:22:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/limasdf@gmail.com/263833019/1

[commit-bot: I haz the power, 2014-05-09 20:07:36]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-09 21:29:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-09 21:29:33]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[tfarina, 2014-05-09 23:33:47]

https://codereview.chromium.org/263833019/diff/1/chrome/browser/ui/app_list/s...
File chrome/browser/ui/app_list/search/app_search_provider.cc (right):

https://codereview.chromium.org/263833019/diff/1/chrome/browser/ui/app_list/s...
chrome/browser/ui/app_list/search/app_search_provider.cc:112: default:
I think you need a break; after RefreshApps(), don't you?

[limasdf, 2014-05-10 02:39:53]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-05-10 02:42:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/limasdf@gmail.com/263833019/20001

[commit-bot: I haz the power, 2014-05-10 06:01:16]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[limasdf, 2014-05-10 11:18:42]

@tfarnia, thanks for picking up my mistake.  I blame myself :/

[commit-bot: I haz the power, 2014-05-10 18:52:27]

Change committed as 269604