Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4491)

Unified Diff: chrome/browser/chromeos/login/reset_browsertest.cc

Issue 263833016: Tests covering additional screens of reset-Rollback option added. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Function added for fake_update_engine_client. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromeos/dbus/fake_update_engine_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/reset_browsertest.cc
diff --git a/chrome/browser/chromeos/login/reset_browsertest.cc b/chrome/browser/chromeos/login/reset_browsertest.cc
index 045671cf61ae709a07dc007d037e6239d1026e3e..759e8c768b9c6a3fd2a822602e665a190d4725e6 100644
--- a/chrome/browser/chromeos/login/reset_browsertest.cc
+++ b/chrome/browser/chromeos/login/reset_browsertest.cc
@@ -206,22 +206,51 @@ IN_PROC_BROWSER_TEST_F(ResetFirstAfterBootTest, PowerwashRequested) {
EXPECT_EQ(0, update_engine_client_->rollback_call_count());
}
-IN_PROC_BROWSER_TEST_F(ResetFirstAfterBootTest, PRE_RollbackRequested) {
+IN_PROC_BROWSER_TEST_F(ResetFirstAfterBootTest, PRE_ErrorOnRollbackRequested) {
PrefService* prefs = g_browser_process->local_state();
prefs->SetBoolean(prefs::kRollbackRequested, true);
prefs->SetBoolean(prefs::kFactoryResetRequested, true);
RegisterSomeUser();
}
-IN_PROC_BROWSER_TEST_F(ResetFirstAfterBootTest, RollbackRequested) {
+IN_PROC_BROWSER_TEST_F(ResetFirstAfterBootTest, ErrorOnRollbackRequested) {
OobeScreenWaiter(OobeDisplay::SCREEN_OOBE_RESET).Wait();
EXPECT_EQ(0, power_manager_client_->num_request_restart_calls());
EXPECT_EQ(0, session_manager_client_->start_device_wipe_call_count());
EXPECT_EQ(0, update_engine_client_->rollback_call_count());
+ JSExpect("!$('reset').classList.contains('revert-promise')");
ClickResetButton();
EXPECT_EQ(0, power_manager_client_->num_request_restart_calls());
EXPECT_EQ(0, session_manager_client_->start_device_wipe_call_count());
EXPECT_EQ(1, update_engine_client_->rollback_call_count());
+ JSExpect("$('reset').classList.contains('revert-promise')");
+ UpdateEngineClient::Status error_update_status;
+ error_update_status.status = UpdateEngineClient::UPDATE_STATUS_ERROR;
+ update_engine_client_->NotifyObserversThatStatusChanged(error_update_status);
+ OobeScreenWaiter(OobeDisplay::SCREEN_ERROR_MESSAGE).Wait();
}
+IN_PROC_BROWSER_TEST_F(ResetFirstAfterBootTest,
+ PRE_SuccessOnRollbackRequested) {
+ PrefService* prefs = g_browser_process->local_state();
+ prefs->SetBoolean(prefs::kRollbackRequested, true);
+ prefs->SetBoolean(prefs::kFactoryResetRequested, true);
+ RegisterSomeUser();
+}
+
+IN_PROC_BROWSER_TEST_F(ResetFirstAfterBootTest, SuccessOnRollbackRequested) {
+ OobeScreenWaiter(OobeDisplay::SCREEN_OOBE_RESET).Wait();
+ ClickResetButton();
+ EXPECT_EQ(0, power_manager_client_->num_request_restart_calls());
+ EXPECT_EQ(0, session_manager_client_->start_device_wipe_call_count());
+ EXPECT_EQ(1, update_engine_client_->rollback_call_count());
+ UpdateEngineClient::Status ready_for_reboot_status;
+ ready_for_reboot_status.status =
+ UpdateEngineClient::UPDATE_STATUS_UPDATED_NEED_REBOOT;
+ update_engine_client_->NotifyObserversThatStatusChanged(
+ ready_for_reboot_status);
+ EXPECT_EQ(1, power_manager_client_->num_request_restart_calls());
+}
+
+
} // namespace chromeos
« no previous file with comments | « no previous file | chromeos/dbus/fake_update_engine_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698