Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 263833016: Tests covering additional screens of reset-Rollback option added. (Closed)

Created:
6 years, 7 months ago by merkulova
Modified:
6 years, 7 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Tests covering additional screens of reset-Rollback option added. BUG=355073 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268844

Patch Set 1 #

Total comments: 1

Patch Set 2 : Function added for fake_update_engine_client. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -2 lines) Patch
M chrome/browser/chromeos/login/reset_browsertest.cc View 1 1 chunk +31 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_update_engine_client.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_update_engine_client.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
merkulova
ygorshenin@ for reset_browsertest derat@ for fake_update_engine_client
6 years, 7 months ago (2014-05-06 08:11:14 UTC) #1
ygorshenin1
lgtm
6 years, 7 months ago (2014-05-06 09:51:00 UTC) #2
Daniel Erat
https://codereview.chromium.org/263833016/diff/1/chromeos/dbus/fake_update_engine_client.cc File chromeos/dbus/fake_update_engine_client.cc (right): https://codereview.chromium.org/263833016/diff/1/chromeos/dbus/fake_update_engine_client.cc#newcode60 chromeos/dbus/fake_update_engine_client.cc:60: FOR_EACH_OBSERVER(Observer, observers_, UpdateStatusChanged(last_status)); this shouldn't be triggered by GetLastStatus() ...
6 years, 7 months ago (2014-05-06 14:49:00 UTC) #3
merkulova
6 years, 7 months ago (2014-05-06 15:52:39 UTC) #4
Daniel Erat
lgtm
6 years, 7 months ago (2014-05-06 16:07:59 UTC) #5
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 7 months ago (2014-05-07 05:53:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/263833016/20001
6 years, 7 months ago (2014-05-07 05:56:15 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-07 17:39:18 UTC) #8
Message was sent while issue was closed.
Change committed as 268844

Powered by Google App Engine
This is Rietveld 408576698