[Android] Ensure MotionEvents are always recycled

[Android] Ensure MotionEvents are always recycled

There were several cases in ContentViewCore where a MotionEvent was obtained
(copied) for offsetting purposes, but was not recycled because of early function
exit. Fix this by recycling the event in the finally clause. Also avoid copying
touch events if the current touch offset is zero.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267980

[jdduke (slow), 2014-05-02 20:02:12]

tedchoc@: PTAL, thanks.

[jdduke (slow), 2014-05-02 20:04:42]

https://codereview.chromium.org/263833013/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/263833013/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1109:
if (mCurrentTouchOffsetX != 0 && mCurrentTouchOffsetY != 0) {
Oops, this should be ||

[Ted C, 2014-05-02 20:08:31]

lgtm

https://codereview.chromium.org/263833013/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/263833013/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1106:
if (mNativeContentViewCore == 0) return false;
I would move these lines up above the offset line above since they have no
dependencies on it.

[jdduke (slow), 2014-05-02 20:19:33]

https://codereview.chromium.org/263833013/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/263833013/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1106:
if (mNativeContentViewCore == 0) return false;
On 2014/05/02 20:08:32, Ted C wrote:
> I would move these lines up above the offset line above since they have no
> dependencies on it.

sgtm, done.

[jdduke (slow), 2014-05-02 20:19:41]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-05-02 20:19:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jdduke@chromium.org/263833013/40001

[commit-bot: I haz the power, 2014-05-02 20:40:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-02 20:40:50]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium

[jdduke (slow), 2014-05-02 21:22:37]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-05-02 21:23:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jdduke@chromium.org/263833013/40001

[commit-bot: I haz the power, 2014-05-03 00:04:23]

Change committed as 267980