Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: src/contexts.h

Issue 263833007: Don't leak contexts in Object.observe (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: cr comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_CONTEXTS_H_ 5 #ifndef V8_CONTEXTS_H_
6 #define V8_CONTEXTS_H_ 6 #define V8_CONTEXTS_H_
7 7
8 #include "heap.h" 8 #include "heap.h"
9 #include "objects.h" 9 #include "objects.h"
10 10
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 V(DERIVED_HAS_TRAP_INDEX, JSFunction, derived_has_trap) \ 167 V(DERIVED_HAS_TRAP_INDEX, JSFunction, derived_has_trap) \
168 V(DERIVED_GET_TRAP_INDEX, JSFunction, derived_get_trap) \ 168 V(DERIVED_GET_TRAP_INDEX, JSFunction, derived_get_trap) \
169 V(DERIVED_SET_TRAP_INDEX, JSFunction, derived_set_trap) \ 169 V(DERIVED_SET_TRAP_INDEX, JSFunction, derived_set_trap) \
170 V(PROXY_ENUMERATE_INDEX, JSFunction, proxy_enumerate) \ 170 V(PROXY_ENUMERATE_INDEX, JSFunction, proxy_enumerate) \
171 V(OBSERVERS_NOTIFY_CHANGE_INDEX, JSFunction, observers_notify_change) \ 171 V(OBSERVERS_NOTIFY_CHANGE_INDEX, JSFunction, observers_notify_change) \
172 V(OBSERVERS_ENQUEUE_SPLICE_INDEX, JSFunction, observers_enqueue_splice) \ 172 V(OBSERVERS_ENQUEUE_SPLICE_INDEX, JSFunction, observers_enqueue_splice) \
173 V(OBSERVERS_BEGIN_SPLICE_INDEX, JSFunction, \ 173 V(OBSERVERS_BEGIN_SPLICE_INDEX, JSFunction, \
174 observers_begin_perform_splice) \ 174 observers_begin_perform_splice) \
175 V(OBSERVERS_END_SPLICE_INDEX, JSFunction, \ 175 V(OBSERVERS_END_SPLICE_INDEX, JSFunction, \
176 observers_end_perform_splice) \ 176 observers_end_perform_splice) \
177 V(NATIVE_OBJECT_OBSERVE_INDEX, JSFunction, \
178 native_object_observe) \
179 V(NATIVE_OBJECT_GET_NOTIFIER_INDEX, JSFunction, \
180 native_object_get_notifier) \
181 V(NATIVE_OBJECT_NOTIFIER_PERFORM_CHANGE, JSFunction, \
182 native_object_notifier_perform_change) \
177 V(SLOPPY_GENERATOR_FUNCTION_MAP_INDEX, Map, sloppy_generator_function_map) \ 183 V(SLOPPY_GENERATOR_FUNCTION_MAP_INDEX, Map, sloppy_generator_function_map) \
178 V(STRICT_GENERATOR_FUNCTION_MAP_INDEX, Map, strict_generator_function_map) \ 184 V(STRICT_GENERATOR_FUNCTION_MAP_INDEX, Map, strict_generator_function_map) \
179 V(GENERATOR_OBJECT_PROTOTYPE_MAP_INDEX, Map, \ 185 V(GENERATOR_OBJECT_PROTOTYPE_MAP_INDEX, Map, \
180 generator_object_prototype_map) \ 186 generator_object_prototype_map) \
181 V(ITERATOR_RESULT_MAP_INDEX, Map, iterator_result_map) \ 187 V(ITERATOR_RESULT_MAP_INDEX, Map, iterator_result_map) \
182 V(MAP_ITERATOR_MAP_INDEX, Map, map_iterator_map) \ 188 V(MAP_ITERATOR_MAP_INDEX, Map, map_iterator_map) \
183 V(SET_ITERATOR_MAP_INDEX, Map, set_iterator_map) 189 V(SET_ITERATOR_MAP_INDEX, Map, set_iterator_map)
184 190
185 // JSFunctions are pairs (context, function code), sometimes also called 191 // JSFunctions are pairs (context, function code), sometimes also called
186 // closures. A Context object is used to represent function contexts and 192 // closures. A Context object is used to represent function contexts and
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
335 PROMISE_CATCH_INDEX, 341 PROMISE_CATCH_INDEX,
336 TO_COMPLETE_PROPERTY_DESCRIPTOR_INDEX, 342 TO_COMPLETE_PROPERTY_DESCRIPTOR_INDEX,
337 DERIVED_HAS_TRAP_INDEX, 343 DERIVED_HAS_TRAP_INDEX,
338 DERIVED_GET_TRAP_INDEX, 344 DERIVED_GET_TRAP_INDEX,
339 DERIVED_SET_TRAP_INDEX, 345 DERIVED_SET_TRAP_INDEX,
340 PROXY_ENUMERATE_INDEX, 346 PROXY_ENUMERATE_INDEX,
341 OBSERVERS_NOTIFY_CHANGE_INDEX, 347 OBSERVERS_NOTIFY_CHANGE_INDEX,
342 OBSERVERS_ENQUEUE_SPLICE_INDEX, 348 OBSERVERS_ENQUEUE_SPLICE_INDEX,
343 OBSERVERS_BEGIN_SPLICE_INDEX, 349 OBSERVERS_BEGIN_SPLICE_INDEX,
344 OBSERVERS_END_SPLICE_INDEX, 350 OBSERVERS_END_SPLICE_INDEX,
351 NATIVE_OBJECT_OBSERVE_INDEX,
352 NATIVE_OBJECT_GET_NOTIFIER_INDEX,
353 NATIVE_OBJECT_NOTIFIER_PERFORM_CHANGE,
345 SLOPPY_GENERATOR_FUNCTION_MAP_INDEX, 354 SLOPPY_GENERATOR_FUNCTION_MAP_INDEX,
346 STRICT_GENERATOR_FUNCTION_MAP_INDEX, 355 STRICT_GENERATOR_FUNCTION_MAP_INDEX,
347 GENERATOR_OBJECT_PROTOTYPE_MAP_INDEX, 356 GENERATOR_OBJECT_PROTOTYPE_MAP_INDEX,
348 ITERATOR_RESULT_MAP_INDEX, 357 ITERATOR_RESULT_MAP_INDEX,
349 MAP_ITERATOR_MAP_INDEX, 358 MAP_ITERATOR_MAP_INDEX,
350 SET_ITERATOR_MAP_INDEX, 359 SET_ITERATOR_MAP_INDEX,
351 360
352 // Properties from here are treated as weak references by the full GC. 361 // Properties from here are treated as weak references by the full GC.
353 // Scavenge treats them as strong references. 362 // Scavenge treats them as strong references.
354 OPTIMIZED_FUNCTIONS_LIST, // Weak. 363 OPTIMIZED_FUNCTIONS_LIST, // Weak.
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
530 static bool IsBootstrappingOrGlobalObject(Isolate* isolate, Object* object); 539 static bool IsBootstrappingOrGlobalObject(Isolate* isolate, Object* object);
531 #endif 540 #endif
532 541
533 STATIC_CHECK(kHeaderSize == Internals::kContextHeaderSize); 542 STATIC_CHECK(kHeaderSize == Internals::kContextHeaderSize);
534 STATIC_CHECK(EMBEDDER_DATA_INDEX == Internals::kContextEmbedderDataIndex); 543 STATIC_CHECK(EMBEDDER_DATA_INDEX == Internals::kContextEmbedderDataIndex);
535 }; 544 };
536 545
537 } } // namespace v8::internal 546 } } // namespace v8::internal
538 547
539 #endif // V8_CONTEXTS_H_ 548 #endif // V8_CONTEXTS_H_
OLDNEW
« no previous file with comments | « src/bootstrapper.cc ('k') | src/object-observe.js » ('j') | src/object-observe.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698