content/browser/service_worker/service_worker_storage_unittest.cc - Issue 2638313002: Manage ServiceWorkerDispatcherHost in ServiceWorkerContextCore

Unified Diff: content/browser/service_worker/service_worker_storage_unittest.cc

Issue 2638313002: Manage ServiceWorkerDispatcherHost in ServiceWorkerContextCore (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « content/browser/service_worker/service_worker_request_handler_unittest.cc ('k') | content/browser/service_worker/service_worker_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_storage_unittest.cc

diff --git a/content/browser/service_worker/service_worker_storage_unittest.cc b/content/browser/service_worker/service_worker_storage_unittest.cc

index 51e0cb6f498363def003daa4791758cb696f1e0f..4f8dfb48c36a791e9690fb4d848ca626b203ac69 100644

--- a/content/browser/service_worker/service_worker_storage_unittest.cc

+++ b/content/browser/service_worker/service_worker_storage_unittest.cc

@@ -1346,11 +1346,9 @@ TEST_F(ServiceWorkerResourceStorageTest, DeleteRegistration_ActiveVersion) {

registration_->SetActiveVersion(registration_->waiting_version());

storage()->UpdateToActiveState(

registration_.get(), base::Bind(&ServiceWorkerUtils::NoOpStatusCallback));

- std::unique_ptr<ServiceWorkerProviderHost> host(new ServiceWorkerProviderHost(

- 33 /* dummy render process id */, MSG_ROUTING_NONE,

- 1 /* dummy provider_id */, SERVICE_WORKER_PROVIDER_FOR_WINDOW,

- ServiceWorkerProviderHost::FrameSecurityLevel::SECURE,

- context()->AsWeakPtr(), NULL));

+ std::unique_ptr<ServiceWorkerProviderHost> host = CreateProviderHostForWindow(

+ 33 /* dummy render process id */, 1 /* dummy provider_id */,

+ true /* is_parent_frame_secure */, context()->AsWeakPtr());

registration_->active_version()->AddControllee(host.get());

bool was_called = false;

@@ -1398,11 +1396,9 @@ TEST_F(ServiceWorkerResourceStorageDiskTest, CleanupOnRestart) {

registration_->SetWaitingVersion(NULL);

storage()->UpdateToActiveState(

registration_.get(), base::Bind(&ServiceWorkerUtils::NoOpStatusCallback));

- std::unique_ptr<ServiceWorkerProviderHost> host(new ServiceWorkerProviderHost(

- 33 /* dummy render process id */, MSG_ROUTING_NONE,

- 1 /* dummy provider_id */, SERVICE_WORKER_PROVIDER_FOR_WINDOW,

- ServiceWorkerProviderHost::FrameSecurityLevel::SECURE,

- context()->AsWeakPtr(), NULL));

+ std::unique_ptr<ServiceWorkerProviderHost> host = CreateProviderHostForWindow(

+ 33 /* dummy render process id */, 1 /* dummy provider_id */,

+ true /* is_parent_frame_secure */, context()->AsWeakPtr());

registration_->active_version()->AddControllee(host.get());

bool was_called = false;

@@ -1558,11 +1554,9 @@ TEST_F(ServiceWorkerResourceStorageTest, UpdateRegistration) {

registration_->SetActiveVersion(registration_->waiting_version());

storage()->UpdateToActiveState(

registration_.get(), base::Bind(&ServiceWorkerUtils::NoOpStatusCallback));

- std::unique_ptr<ServiceWorkerProviderHost> host(new ServiceWorkerProviderHost(

- 33 /* dummy render process id */, MSG_ROUTING_NONE,

- 1 /* dummy provider_id */, SERVICE_WORKER_PROVIDER_FOR_WINDOW,

- ServiceWorkerProviderHost::FrameSecurityLevel::SECURE,

- context()->AsWeakPtr(), NULL));

+ std::unique_ptr<ServiceWorkerProviderHost> host = CreateProviderHostForWindow(

+ 33 /* dummy render process id */, 1 /* dummy provider_id */,

+ true /* is_parent_frame_secure */, helper_->context()->AsWeakPtr());

registration_->active_version()->AddControllee(host.get());

bool was_called = false;