Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.h

Issue 2638313002: Manage ServiceWorkerDispatcherHost in ServiceWorkerContextCore (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_dispatcher_host.h
diff --git a/content/browser/service_worker/service_worker_dispatcher_host.h b/content/browser/service_worker/service_worker_dispatcher_host.h
index e33a7e8901b3e934a1d8c5c078e9a2bdab9ba1f9..cfa7045b513423bdfdee4cf789a8372c67d6903b 100644
--- a/content/browser/service_worker/service_worker_dispatcher_host.h
+++ b/content/browser/service_worker/service_worker_dispatcher_host.h
@@ -88,6 +88,10 @@ class CONTENT_EXPORT ServiceWorkerDispatcherHost
friend class base::DeleteHelper<ServiceWorkerDispatcherHost>;
friend class ServiceWorkerDispatcherHostTest;
friend class TestingServiceWorkerDispatcherHost;
+ FRIEND_TEST_ALL_PREFIXES(ServiceWorkerDispatcherHostTest,
+ ProviderCreatedAndDestroyed);
+ FRIEND_TEST_ALL_PREFIXES(ServiceWorkerDispatcherHostTest,
+ CleanupOnRendererCrash);
using StatusCallback = base::Callback<void(ServiceWorkerStatusCode status)>;
enum class ProviderStatus { OK, NO_CONTEXT, DEAD_HOST, NO_HOST, NO_URL };
@@ -97,10 +101,7 @@ class CONTENT_EXPORT ServiceWorkerDispatcherHost
void AddMojoBinding(mojo::ScopedInterfaceEndpointHandle handle);
// mojom::ServiceWorkerDispatcherHost implementation
- void OnProviderCreated(int provider_id,
- int route_id,
- ServiceWorkerProviderType provider_type,
- bool is_parent_frame_secure) override;
+ void OnProviderCreated(ServiceWorkerProviderHostInfo info) override;
void OnProviderDestroyed(int provider_id) override;
void OnSetHostedVersionId(int provider_id,
int64_t version_id,

Powered by Google App Engine
This is Rietveld 408576698