Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: content/browser/service_worker/service_worker_context_request_handler_unittest.cc

Issue 2638313002: Manage ServiceWorkerDispatcherHost in ServiceWorkerContextCore (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_context_request_handler_unittest.cc
diff --git a/content/browser/service_worker/service_worker_context_request_handler_unittest.cc b/content/browser/service_worker/service_worker_context_request_handler_unittest.cc
index c6ed19f81188e95fd3d59af656579649a1cbfe01..cae7d7e543211aa804d114662a9d4effbd910079 100644
--- a/content/browser/service_worker/service_worker_context_request_handler_unittest.cc
+++ b/content/browser/service_worker/service_worker_context_request_handler_unittest.cc
@@ -87,13 +87,10 @@ class ServiceWorkerContextRequestHandlerTest : public testing::Test {
ServiceWorkerContextCore* context() const { return helper_->context(); }
void SetUpProvider() {
- std::unique_ptr<ServiceWorkerProviderHost> host(
- new ServiceWorkerProviderHost(
- helper_->mock_render_process_id(),
- MSG_ROUTING_NONE /* render_frame_id */, 1 /* provider_id */,
- SERVICE_WORKER_PROVIDER_FOR_CONTROLLER,
- ServiceWorkerProviderHost::FrameSecurityLevel::SECURE,
- context()->AsWeakPtr(), nullptr));
+ std::unique_ptr<ServiceWorkerProviderHost> host =
+ CreateProviderHostForServiceWorkerContext(
+ helper_->mock_render_process_id(), 1 /* provider_id */,
+ true /* is_parent_frame_secure */, context()->AsWeakPtr());
provider_host_ = host->AsWeakPtr();
context()->AddProviderHost(std::move(host));
provider_host_->running_hosted_version_ = version_;

Powered by Google App Engine
This is Rietveld 408576698