Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: content/browser/service_worker/embedded_worker_registry.h

Issue 2638313002: Manage ServiceWorkerDispatcherHost in ServiceWorkerContextCore (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/embedded_worker_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/embedded_worker_registry.h
diff --git a/content/browser/service_worker/embedded_worker_registry.h b/content/browser/service_worker/embedded_worker_registry.h
index 8561ce4816430f757214017c0198590a970721e6..75b7666cad52371ab84242ee06aa7b6926c86fbb 100644
--- a/content/browser/service_worker/embedded_worker_registry.h
+++ b/content/browser/service_worker/embedded_worker_registry.h
@@ -10,7 +10,6 @@
#include <set>
#include <vector>
-#include "base/callback_forward.h"
#include "base/gtest_prod_util.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
@@ -23,7 +22,6 @@ class GURL;
namespace IPC {
class Message;
-class Sender;
}
namespace content {
@@ -39,8 +37,6 @@ class ServiceWorkerContextCore;
class CONTENT_EXPORT EmbeddedWorkerRegistry
: public NON_EXPORTED_BASE(base::RefCounted<EmbeddedWorkerRegistry>) {
public:
- typedef base::Callback<void(ServiceWorkerStatusCode)> StatusCallback;
-
static scoped_refptr<EmbeddedWorkerRegistry> Create(
const base::WeakPtr<ServiceWorkerContextCore>& contxet);
@@ -88,9 +84,13 @@ class CONTENT_EXPORT EmbeddedWorkerRegistry
int line_number,
const GURL& source_url);
- // Keeps a map from process_id to sender information.
- void AddChildProcessSender(int process_id, IPC::Sender* sender);
- void RemoveChildProcessSender(int process_id);
+ // Removes information about the service workers running on the process and
+ // calls ServiceWorkerVersion::OnDetached() on each. Called when the process
+ // is terminated. Under normal operation, the workers should already have
+ // been stopped before the process is terminated, in which case this function
+ // does nothing. But in some cases the process can be terminated unexpectedly
+ // or the workers can fail to stop cleanly.
+ void RemoveProcess(int process_id);
// Returns an embedded worker instance for given |embedded_worker_id|.
EmbeddedWorkerInstance* GetWorker(int embedded_worker_id);
@@ -107,7 +107,6 @@ class CONTENT_EXPORT EmbeddedWorkerRegistry
RemoveWorkerInSharedProcess);
using WorkerInstanceMap = std::map<int, EmbeddedWorkerInstance*>;
- using ProcessToSenderMap = std::map<int, IPC::Sender*>;
EmbeddedWorkerRegistry(
const base::WeakPtr<ServiceWorkerContextCore>& context,
@@ -136,7 +135,6 @@ class CONTENT_EXPORT EmbeddedWorkerRegistry
base::WeakPtr<ServiceWorkerContextCore> context_;
WorkerInstanceMap worker_map_;
- ProcessToSenderMap process_sender_map_;
// Map from process_id to embedded_worker_id.
// This map only contains starting and running workers.
« no previous file with comments | « no previous file | content/browser/service_worker/embedded_worker_registry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698