Chromium Code Reviews| Index: content/common/service_worker/service_worker.mojom |
| diff --git a/content/common/service_worker/service_worker.mojom b/content/common/service_worker/service_worker.mojom |
| index 840a3efdc575d57a070b4347144b7eab987133c7..709c328c9a9782ebe79aabe9c18efcb8725bce9d 100644 |
| --- a/content/common/service_worker/service_worker.mojom |
| +++ b/content/common/service_worker/service_worker.mojom |
| @@ -4,18 +4,37 @@ |
| module content.mojom; |
| -import "content/common/service_worker/service_worker_types.mojom"; |
| +import "content/common/service_worker/service_worker_provider.mojom"; |
| // Per-process browser-side interface bound to ServiceWorkerDispatcherHost. |
| // Each InterfacePtrs on the same render process will be bound to the same |
| // ServiceWorkerDispatcherHost. |
| interface ServiceWorkerDispatcherHost { |
| - OnProviderCreated(int32 provider_id, |
| - int32 route_id, |
| - ServiceWorkerProviderType provider_type, |
| - bool is_parent_frame_secure); |
| + // Informs the browser of a new ServiceWorkerProvider in the child process, |
| + // |provider_id| is unique within its child process. When this provider is |
|
horo
2017/01/26 02:40:23
These comments should be in service_worker_provide
shimazu
2017/01/26 09:27:23
Acknowledged.
shimazu
2017/02/07 08:47:02
Done.
|
| + // created for a document, |route_id| is the frame ID of it. When this |
| + // provider is created for a Shared Worker, |route_id| is the Shared Worker |
| + // route ID. When this provider is created for a Service Worker, |route_id| is |
| + // MSG_ROUTING_NONE. |provider_type| identifies whether this provider is for |
| + // Service Worker controllees (documents and Shared Workers) or for |
| + // controllers (Service Workers). |
| + // |
| + // |is_parent_frame_secure| is false if the provider is created for a |
| + // document whose parent frame is not secure from the point of view of the |
| + // document; that is, blink::WebFrame::canHaveSecureChild() returns false. |
| + // This doesn't mean the document is necessarily an insecure context, |
| + // because the document may have a URL whose scheme is granted an exception |
| + // that allows bypassing the ancestor secure context check. See the |
| + // comment in blink::Document::isSecureContextImpl for more details. |
| + // If the provider is not created for a document, or the document does not |
| + // have a parent frame, |is_parent_frame_secure| is true. |
| + OnProviderCreated(ServiceWorkerProviderHostInfo provider_info); |
| OnProviderDestroyed(int32 provider_id); |
| - // Make relationship between the network provider and the service worker |
| + |
| + // Informs the browser that a service worker is starting up in a provider. |
| + // |provider_id| identifies the ServiceWorkerProviderHost hosting the service |
| + // worker. |version_id| identifies the ServiceWorkerVersion and |
| + // |embedded_worker_id| identifies the EmbeddedWorkerInstance. |
| OnSetHostedVersionId(int32 provider_id, |
| int64 version_id, |
| int32 embedded_worker_id); |