Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: content/browser/service_worker/foreign_fetch_request_handler_unittest.cc

Issue 2638313002: Manage ServiceWorkerDispatcherHost in ServiceWorkerContextCore (Closed)
Patch Set: Add a newline Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/foreign_fetch_request_handler_unittest.cc
diff --git a/content/browser/service_worker/foreign_fetch_request_handler_unittest.cc b/content/browser/service_worker/foreign_fetch_request_handler_unittest.cc
index 5727b00828f02dee986839c5849f1f261a56d47d..f2d6bd199c956fdd2e4f200b7cf9e61fd39f6f27 100644
--- a/content/browser/service_worker/foreign_fetch_request_handler_unittest.cc
+++ b/content/browser/service_worker/foreign_fetch_request_handler_unittest.cc
@@ -76,12 +76,12 @@ class ForeignFetchRequestHandlerTest : public testing::Test {
version_->set_foreign_fetch_scopes({kScope});
// An empty host.
- std::unique_ptr<ServiceWorkerProviderHost> host(
- new ServiceWorkerProviderHost(
- helper_->mock_render_process_id(), MSG_ROUTING_NONE,
- kMockProviderId, SERVICE_WORKER_PROVIDER_FOR_WINDOW,
- ServiceWorkerProviderHost::FrameSecurityLevel::SECURE,
- context()->AsWeakPtr(), nullptr));
+ std::unique_ptr<ServiceWorkerProviderHost> host =
+ ServiceWorkerProviderHost::CreateForTesting(
+ helper_->mock_render_process_id(), kMockProviderId,
+ SERVICE_WORKER_PROVIDER_FOR_WINDOW,
+ helper_->context()->AsWeakPtr());
+ host->set_parent_frame_secure(true);
host->SetDocumentUrl(GURL("https://host/scope/"));
provider_host_ = host->AsWeakPtr();
context()->AddProviderHost(std::move(host));
@@ -163,12 +163,11 @@ class ForeignFetchRequestHandlerTest : public testing::Test {
}
void CreateServiceWorkerTypeProviderHost() {
- std::unique_ptr<ServiceWorkerProviderHost> host(
- new ServiceWorkerProviderHost(
- helper_->mock_render_process_id(), MSG_ROUTING_NONE,
- kMockProviderId, SERVICE_WORKER_PROVIDER_FOR_CONTROLLER,
- ServiceWorkerProviderHost::FrameSecurityLevel::UNINITIALIZED,
- context()->AsWeakPtr(), nullptr));
+ std::unique_ptr<ServiceWorkerProviderHost> host =
+ ServiceWorkerProviderHost::CreateForTesting(
+ helper_->mock_render_process_id(), kMockProviderId,
+ SERVICE_WORKER_PROVIDER_FOR_CONTROLLER,
+ helper_->context()->AsWeakPtr());
provider_host_ = host->AsWeakPtr();
context()->RemoveProviderHost(host->process_id(), host->provider_id());
context()->AddProviderHost(std::move(host));

Powered by Google App Engine
This is Rietveld 408576698