Issue 263823013: Remove the checks for component=shared_library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 263823013: Remove the checks for component=shared_library. (Closed)

Created:
6 years, 7 months ago by M-A Ruel

Modified:
5 years, 11 months ago

Reviewers:
jungshik at Google

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/icu46/

Visibility:
Public.

More Reviews

Description

Remove the checks for component=shared_library. This is not needed anymore, src/tools/isolate_driver.py parses the ninja files to figure out the .so/.dylib/.dll needed automatically. R=jshin@chromium.org BUG=336439

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -24 lines)			Patch
	M	icu.isolate	View		1 chunk	+0 lines, -24 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

The new wrapper script removes the need for this micro management so this can now ...

6 years, 7 months ago (2014-05-06 17:00:50 UTC) #1

M-A Ruel

On 2014/05/06 17:00:50, M-A Ruel wrote: > The new wrapper script removes the need for ...

6 years, 7 months ago (2014-05-08 18:30:56 UTC) #2

jungshik at Google

6 years, 7 months ago (2014-05-08 20:10:45 UTC) #3

On 2014/05/08 18:30:56, M-A Ruel wrote:
> On 2014/05/06 17:00:50, M-A Ruel wrote:
> > The new wrapper script removes the need for this micro management so this
can
> > now be removed.
> 
> Ping

Sorry. LGTM. I'll port this change to icu52 tree that I'm trying to roll in (I'm
fixing test failures here and there). You can check this in in the meantime for
icu46.

Expand Messages | Collapse Messages