pkg/analysis_server/lib/src/services/correction/util.dart - Issue 2638183002: Issue 28027. Move Null to the bottom in the Analyzer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/correction/util.dart

Issue 2638183002: Issue 28027. Move Null to the bottom in the Analyzer. (Closed)

Patch Set: Fixes for review comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analysis_server/lib/src/services/correction/util.dart

diff --git a/pkg/analysis_server/lib/src/services/correction/util.dart b/pkg/analysis_server/lib/src/services/correction/util.dart

index 82217a2d4d24ea9c19fa2ee91e855de36d1123f3..cbed44a227bcd1e53787c338cf2d96dc668acb90 100644

--- a/pkg/analysis_server/lib/src/services/correction/util.dart

+++ b/pkg/analysis_server/lib/src/services/correction/util.dart

@@ -1129,8 +1129,8 @@ class CorrectionUtils {

parametersBuffer.write(')');

return getTypeSource(type.returnType, librariesToImport);

}

- // BottomType

- if (type.isBottom) {

+ // <Bottom>, Null

+ if (type.isBottom || type.isDartCoreNull) {

return 'dynamic';

}

// prepare element