pkg/analysis_server/lib/src/services/correction/assist_internal.dart - Issue 2638183002: Issue 28027. Move Null to the bottom in the Analyzer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/correction/assist_internal.dart

Issue 2638183002: Issue 28027. Move Null to the bottom in the Analyzer. (Closed)

Patch Set: Fixes for review comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analysis_server/lib/src/services/correction/assist_internal.dart

diff --git a/pkg/analysis_server/lib/src/services/correction/assist_internal.dart b/pkg/analysis_server/lib/src/services/correction/assist_internal.dart

index 27cc2cf5c3580e0d3031e52eaa4bff1b14ce0c46..c92920d7e650d371d596d3d455f8b648c20c6b14 100644

--- a/pkg/analysis_server/lib/src/services/correction/assist_internal.dart

+++ b/pkg/analysis_server/lib/src/services/correction/assist_internal.dart

@@ -338,7 +338,7 @@ class AssistProcessor {

DartType type = initializer.bestType;

// prepare type source

String typeSource;

- if (type is InterfaceType || type is FunctionType) {

+ if (type is InterfaceType && !type.isDartCoreNull || type is FunctionType) {

_configureTargetLocation(node);

Set<Source> librariesToImport = new Set<Source>();

typeSource = utils.getTypeSource(type, librariesToImport);

« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/correction/fix_internal.dart » ('j') | no next file with comments »