Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1623)

Unified Diff: runtime/vm/symbols.cc

Issue 2638173002: Compact the symbol table when creating core snapshots or JIT app snapshots. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/symbols.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/symbols.cc
diff --git a/runtime/vm/symbols.cc b/runtime/vm/symbols.cc
index 0d952892b7abf7a96305f7f552509eabf76ce092..38d5520ffa895c726b77c824315528d7ac0602c9 100644
--- a/runtime/vm/symbols.cc
+++ b/runtime/vm/symbols.cc
@@ -354,7 +354,6 @@ RawArray* Symbols::UnifiedSymbolTable() {
}
-#if defined(DART_PRECOMPILER)
void Symbols::Compact(Isolate* isolate) {
ASSERT(isolate != Dart::vm_isolate());
Zone* zone = Thread::Current()->zone();
@@ -397,7 +396,6 @@ void Symbols::Compact(Isolate* isolate) {
}
isolate->object_store()->set_symbol_table(table.Release());
}
-#endif // DART_PRECOMPILER
void Symbols::GetStats(Isolate* isolate, intptr_t* size, intptr_t* capacity) {
@@ -702,21 +700,19 @@ RawString* Symbols::FromCharCode(Thread* thread, int32_t char_code) {
}
-void Symbols::DumpStats() {
- if (FLAG_dump_symbol_stats) {
- intptr_t size = -1;
- intptr_t capacity = -1;
- // First dump VM symbol table stats.
- GetStats(Dart::vm_isolate(), &size, &capacity);
- OS::Print("VM Isolate: Number of symbols : %" Pd "\n", size);
- OS::Print("VM Isolate: Symbol table capacity : %" Pd "\n", capacity);
- // Now dump regular isolate symbol table stats.
- GetStats(Isolate::Current(), &size, &capacity);
- OS::Print("Isolate: Number of symbols : %" Pd "\n", size);
- OS::Print("Isolate: Symbol table capacity : %" Pd "\n", capacity);
- // TODO(koda): Consider recording growth and collision stats in HashTable,
- // in DEBUG mode.
- }
+void Symbols::DumpStats(Isolate* isolate) {
+ intptr_t size = -1;
+ intptr_t capacity = -1;
+ // First dump VM symbol table stats.
+ GetStats(Dart::vm_isolate(), &size, &capacity);
+ OS::Print("VM Isolate: Number of symbols : %" Pd "\n", size);
+ OS::Print("VM Isolate: Symbol table capacity : %" Pd "\n", capacity);
+ // Now dump regular isolate symbol table stats.
+ GetStats(isolate, &size, &capacity);
+ OS::Print("Isolate: Number of symbols : %" Pd "\n", size);
+ OS::Print("Isolate: Symbol table capacity : %" Pd "\n", capacity);
+ // TODO(koda): Consider recording growth and collision stats in HashTable,
+ // in DEBUG mode.
}
« no previous file with comments | « runtime/vm/symbols.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698