Compact the symbol table when creating core snapshots or JIT app snapshots.

runtime/vm/symbols.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/symbols.h"
 
 #include "vm/handles.h"
 #include "vm/hash_table.h"
 #include "vm/isolate.h"
 #include "vm/object.h"
@@ skipping 336 matching lines @@
     ASSERT(!symbol.IsNull());
     bool present = unified_table.Insert(symbol);
     ASSERT(!present);
   }
   table.Release();
 
   return unified_table.Release().raw();
 }
 
 
-#if defined(DART_PRECOMPILER)
 void Symbols::Compact(Isolate* isolate) {
   ASSERT(isolate != Dart::vm_isolate());
   Zone* zone = Thread::Current()->zone();
 
   // 1. Drop the symbol table and do a full garbage collection.
   isolate->object_store()->set_symbol_table(Object::empty_array());
   isolate->heap()->CollectAllGarbage();
 
   // 2. Walk the heap to find surviving symbols.
   GrowableArray<String*> symbols;
@@ skipping 22 matching lines @@
   SymbolTable table(zone, array.raw());
   for (intptr_t i = 0; i < symbols.length(); i++) {
     String& symbol = *symbols[i];
     ASSERT(symbol.IsString());
     ASSERT(symbol.IsCanonical());
     bool present = table.Insert(symbol);
     ASSERT(!present);
   }
   isolate->object_store()->set_symbol_table(table.Release());
 }
-#endif  // DART_PRECOMPILER
 
 
 void Symbols::GetStats(Isolate* isolate, intptr_t* size, intptr_t* capacity) {
   ASSERT(isolate != NULL);
   SymbolTable table(isolate->object_store()->symbol_table());
   *size = table.NumOccupied();
   *capacity = table.NumEntries();
   table.Release();
 }
 
@@ skipping 284 matching lines @@
 
 
 RawString* Symbols::FromCharCode(Thread* thread, int32_t char_code) {
   if (char_code > kMaxOneCharCodeSymbol) {
     return FromUTF32(thread, &char_code, 1);
   }
   return predefined_[char_code];
 }
 
 
-void Symbols::DumpStats() {
-  if (FLAG_dump_symbol_stats) {
-    intptr_t size = -1;
-    intptr_t capacity = -1;
-    // First dump VM symbol table stats.
-    GetStats(Dart::vm_isolate(), &size, &capacity);
-    OS::Print("VM Isolate: Number of symbols : %" Pd "\n", size);
-    OS::Print("VM Isolate: Symbol table capacity : %" Pd "\n", capacity);
-    // Now dump regular isolate symbol table stats.
-    GetStats(Isolate::Current(), &size, &capacity);
-    OS::Print("Isolate: Number of symbols : %" Pd "\n", size);
-    OS::Print("Isolate: Symbol table capacity : %" Pd "\n", capacity);
-    // TODO(koda): Consider recording growth and collision stats in HashTable,
-    // in DEBUG mode.
-  }
+void Symbols::DumpStats(Isolate* isolate) {
+  intptr_t size = -1;
+  intptr_t capacity = -1;
+  // First dump VM symbol table stats.
+  GetStats(Dart::vm_isolate(), &size, &capacity);
+  OS::Print("VM Isolate: Number of symbols : %" Pd "\n", size);
+  OS::Print("VM Isolate: Symbol table capacity : %" Pd "\n", capacity);
+  // Now dump regular isolate symbol table stats.
+  GetStats(isolate, &size, &capacity);
+  OS::Print("Isolate: Number of symbols : %" Pd "\n", size);
+  OS::Print("Isolate: Symbol table capacity : %" Pd "\n", capacity);
+  // TODO(koda): Consider recording growth and collision stats in HashTable,
+  // in DEBUG mode.
 }
 
 
 intptr_t Symbols::LookupPredefinedSymbol(RawObject* obj) {
   for (intptr_t i = 1; i < Symbols::kMaxPredefinedId; i++) {
     if (symbol_handles_[i]->raw() == obj) {
       return (i + kMaxPredefinedObjectIds);
     }
   }
   return kInvalidIndex;
 }
 
 
 RawObject* Symbols::GetPredefinedSymbol(intptr_t object_id) {
   ASSERT(IsPredefinedSymbolId(object_id));
   intptr_t i = (object_id - kMaxPredefinedObjectIds);
   if ((i > kIllegal) && (i < Symbols::kMaxPredefinedId)) {
     return symbol_handles_[i]->raw();
   }
   return Object::null();
 }
 
 }  // namespace dart