[Turbofan] Add other integer SIMD types, add more integer ops.

src/compiler/graph.h

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_GRAPH_H_
 #define V8_COMPILER_GRAPH_H_
 
 #include "src/base/compiler-specific.h"
 #include "src/globals.h"
 #include "src/zone/zone-containers.h"
@@ skipping 48 matching lines @@
                          Node* const* inputs, bool incomplete = false);
 
   // Factory that checks the input count.
   Node* NewNode(const Operator* op, int input_count, Node* const* inputs,
                 bool incomplete = false);
 
   // Factories for nodes with static input counts.
   Node* NewNode(const Operator* op) {
     return NewNode(op, 0, static_cast<Node* const*>(nullptr));
   }
-  Node* NewNode(const Operator* op, Node* n1) { return NewNode(op, 1, &n1); }
-  Node* NewNode(const Operator* op, Node* n1, Node* n2) {
-    Node* nodes[] = {n1, n2};
-    return NewNode(op, arraysize(nodes), nodes);
-  }
-  Node* NewNode(const Operator* op, Node* n1, Node* n2, Node* n3) {
-    Node* nodes[] = {n1, n2, n3};
-    return NewNode(op, arraysize(nodes), nodes);
-  }
-  Node* NewNode(const Operator* op, Node* n1, Node* n2, Node* n3, Node* n4) {
-    Node* nodes[] = {n1, n2, n3, n4};
-    return NewNode(op, arraysize(nodes), nodes);
-  }
-  Node* NewNode(const Operator* op, Node* n1, Node* n2, Node* n3, Node* n4,
-                Node* n5) {
-    Node* nodes[] = {n1, n2, n3, n4, n5};
-    return NewNode(op, arraysize(nodes), nodes);
-  }
-  Node* NewNode(const Operator* op, Node* n1, Node* n2, Node* n3, Node* n4,
-                Node* n5, Node* n6) {
-    Node* nodes[] = {n1, n2, n3, n4, n5, n6};
-    return NewNode(op, arraysize(nodes), nodes);
-  }
-  Node* NewNode(const Operator* op, Node* n1, Node* n2, Node* n3, Node* n4,
-                Node* n5, Node* n6, Node* n7) {
-    Node* nodes[] = {n1, n2, n3, n4, n5, n6, n7};
-    return NewNode(op, arraysize(nodes), nodes);
-  }
-  Node* NewNode(const Operator* op, Node* n1, Node* n2, Node* n3, Node* n4,
-                Node* n5, Node* n6, Node* n7, Node* n8) {
-    Node* nodes[] = {n1, n2, n3, n4, n5, n6, n7, n8};
-    return NewNode(op, arraysize(nodes), nodes);
-  }
-  Node* NewNode(const Operator* op, Node* n1, Node* n2, Node* n3, Node* n4,
-                Node* n5, Node* n6, Node* n7, Node* n8, Node* n9) {
-    Node* nodes[] = {n1, n2, n3, n4, n5, n6, n7, n8, n9};
-    return NewNode(op, arraysize(nodes), nodes);
+  Node* NewNode(const Operator* op, Node* n) { return NewNode(op, 1, &n); }

[titzer, 2017/01/25 09:47:25]

This is a nice simplification, but IIRC there was a reason we didn't do this
yet. Might trigger a perf alert. Separate CL?

[bbudge, 2017/01/26 02:04:43]

Agreed. Changed to explicit overloads up to 17 params.

+  // Factories for nodes with more than one input.
+  template <typename... Nodes>
+  Node* NewNode(const Operator* op, Nodes*... nodes) {
+    Node* arr[] = {nodes...};
+    return NewNode(op, arraysize(arr), arr);
   }
 
   // Clone the {node}, and assign a new node id to the copy.
   Node* CloneNode(const Node* node);
 
   Zone* zone() const { return zone_; }
   Node* start() const { return start_; }
   Node* end() const { return end_; }
 
   void SetStart(Node* start) { start_ = start; }
@@ skipping 30 matching lines @@
  public:
   virtual ~GraphDecorator() {}
   virtual void Decorate(Node* node) = 0;
 };
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_GRAPH_H_