Take a screenshot in maximize mode when volume down and power are pressed.

Take a screenshot in maximize mode when volume down and power are pressed.

BUG=363732
TEST=MaximizeModeControllerTest.Screenshot
TEST=When device is in maximize mode, hold volume down and press power to take a screenshot.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269684

[flackr, 2014-05-01 14:45:08]

Hey, this takes a screenshot when volume down and power is pressed. Since the
screenshot is requested on the press of the power key this happens before the
lock screen animation, though when issue 364584 we'll have to consider whether
to delay the volume notification to allow taking screenshots without the volume
popup bubble. Please take a look, thanks!

[sadrul, 2014-05-02 00:59:08]

https://codereview.chromium.org/263813002/diff/60001/ash/wm/maximize_mode/max...
File ash/wm/maximize_mode/maximize_mode_event_blocker.cc (right):

https://codereview.chromium.org/263813002/diff/60001/ash/wm/maximize_mode/max...
ash/wm/maximize_mode/maximize_mode_event_blocker.cc:77:
screenshot_delegate->HandleTakeScreenshotForAllRootWindows();
I suspect this will need to be merged with bruthig@s CL.

A better way of doing this would be to do
accelerator_controller()->PerformAction()

I am not a huge fan of doing things other than targeting from a targeter. Is
this something we could do in the accelerator-controller instead? We have
accelerators that are allowed only in app mode, or not allowed in login/lock
screen. Perhaps we could have accelerators that are allowed only in
maximize-mode? Or have a MaximizeModeKeyHandler event-handler that does this
instead of doing it from here?

[flackr, 2014-05-07 04:08:44]

I've verified the test will pass when the EventTargeter no longer blocks the
events. Please take a look, thanks!

https://codereview.chromium.org/263813002/diff/60001/ash/wm/maximize_mode/max...
File ash/wm/maximize_mode/maximize_mode_event_blocker.cc (right):

https://codereview.chromium.org/263813002/diff/60001/ash/wm/maximize_mode/max...
ash/wm/maximize_mode/maximize_mode_event_blocker.cc:77:
screenshot_delegate->HandleTakeScreenshotForAllRootWindows();
On 2014/05/02 00:59:08, sadrul wrote:
> I suspect this will need to be merged with bruthig@s CL.

Now it's just dependent on it, though I suspect also needs to have the POWER key
not retargeted.

> A better way of doing this would be to do
> accelerator_controller()->PerformAction()

Done.

> 
> I am not a huge fan of doing things other than targeting from a targeter. Is
> this something we could do in the accelerator-controller instead? We have
> accelerators that are allowed only in app mode, or not allowed in login/lock
> screen. Perhaps we could have accelerators that are allowed only in
> maximize-mode? Or have a MaximizeModeKeyHandler event-handler that does this
> instead of doing it from here?

The only multi-key accelerator handling we have is for specific modifier keys,
Ctrl, Alt, etc.
https://code.google.com/p/chromium/codesearch#chromium/src/ui/events/event_co....
If I did that would I add volume down as a modifier to support adding it to
accelerator_table or add special key handling for this accelerator?

Given that potential complexity, I prefer doing this as a maximize mode event
handler, which also keeps the handling local. Done.

[sadrul, 2014-05-07 13:50:00]

cool! LGTM

[flackr, 2014-05-09 18:41:02]

The CQ bit was checked by flackr@chromium.org

[commit-bot: I haz the power, 2014-05-09 18:44:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/flackr@chromium.org/263813002/100001

[commit-bot: I haz the power, 2014-05-09 20:53:29]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-09 20:58:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-09 20:58:26]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[flackr, 2014-05-10 02:54:40]

+oshima for ash/test, moved the test delegate class from
lock_state_controller_unittest.cc

[oshima, 2014-05-10 14:59:22]

lgtm

[flackr, 2014-05-10 15:06:59]

The CQ bit was checked by flackr@chromium.org

[commit-bot: I haz the power, 2014-05-10 15:08:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/flackr@chromium.org/263813002/120001

[commit-bot: I haz the power, 2014-05-10 15:37:29]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-10 15:42:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-10 15:42:05]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[flackr, 2014-05-10 17:57:06]

The CQ bit was checked by flackr@chromium.org

[commit-bot: I haz the power, 2014-05-10 17:58:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/flackr@chromium.org/263813002/140001

[commit-bot: I haz the power, 2014-05-11 01:41:38]

Change committed as 269684