Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2638033002: Remove some hacks in the testing scripts & prepare for checked mode handling with kernel (Closed)

Created:
3 years, 11 months ago by kustermann
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove some hacks in the testing scripts & prepare for checked mode handling with kernel R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/ef019665e73468ae38b2c3ef436ceb8b9fedf74d

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -37 lines) Patch
M tools/testing/dart/compiler_configuration.dart View 5 chunks +33 lines, -19 lines 1 comment Download
M tools/testing/dart/runtime_configuration.dart View 1 chunk +1 line, -9 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kustermann
https://codereview.chromium.org/2638033002/diff/1/tools/testing/dart/compiler_configuration.dart File tools/testing/dart/compiler_configuration.dart (right): https://codereview.chromium.org/2638033002/diff/1/tools/testing/dart/compiler_configuration.dart#newcode713 tools/testing/dart/compiler_configuration.dart:713: } Maybe I can also get rid of this ...
3 years, 11 months ago (2017-01-17 15:19:54 UTC) #2
Bill Hesse
lgtm
3 years, 11 months ago (2017-01-17 16:26:59 UTC) #3
kustermann
3 years, 11 months ago (2017-01-18 11:11:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ef019665e73468ae38b2c3ef436ceb8b9fedf74d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698