Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: src/mips/lithium-mips.cc

Issue 263803005: Fix crash in debug builds introduced with r21110. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-mips.h ('k') | src/x64/lithium-codegen-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "v8.h" 5 #include "v8.h"
6 6
7 #include "lithium-allocator-inl.h" 7 #include "lithium-allocator-inl.h"
8 #include "mips/lithium-mips.h" 8 #include "mips/lithium-mips.h"
9 #include "mips/lithium-codegen-mips.h" 9 #include "mips/lithium-codegen-mips.h"
10 #include "hydrogen-osr.h" 10 #include "hydrogen-osr.h"
(...skipping 410 matching lines...) Expand 10 before | Expand all | Expand 10 after
421 HBasicBlock* next = NULL; 421 HBasicBlock* next = NULL;
422 if (i < blocks->length() - 1) next = blocks->at(i + 1); 422 if (i < blocks->length() - 1) next = blocks->at(i + 1);
423 DoBasicBlock(blocks->at(i), next); 423 DoBasicBlock(blocks->at(i), next);
424 if (is_aborted()) return NULL; 424 if (is_aborted()) return NULL;
425 } 425 }
426 status_ = DONE; 426 status_ = DONE;
427 return chunk_; 427 return chunk_;
428 } 428 }
429 429
430 430
431 void LCodeGen::Abort(BailoutReason reason) { 431 void LChunkBuilder::Abort(BailoutReason reason) {
432 info()->set_bailout_reason(reason); 432 info()->set_bailout_reason(reason);
433 status_ = ABORTED; 433 status_ = ABORTED;
434 } 434 }
435 435
436 436
437 void LChunkBuilder::AddDeprecationDependency(Handle<Map> map) {
438 if (map->is_deprecated()) return Abort(kMapBecameDeprecated);
439 chunk_->AddDeprecationDependency(map);
440 }
441
442
443 LUnallocated* LChunkBuilder::ToUnallocated(Register reg) { 437 LUnallocated* LChunkBuilder::ToUnallocated(Register reg) {
444 return new(zone()) LUnallocated(LUnallocated::FIXED_REGISTER, 438 return new(zone()) LUnallocated(LUnallocated::FIXED_REGISTER,
445 Register::ToAllocationIndex(reg)); 439 Register::ToAllocationIndex(reg));
446 } 440 }
447 441
448 442
449 LUnallocated* LChunkBuilder::ToUnallocated(DoubleRegister reg) { 443 LUnallocated* LChunkBuilder::ToUnallocated(DoubleRegister reg) {
450 return new(zone()) LUnallocated(LUnallocated::FIXED_DOUBLE_REGISTER, 444 return new(zone()) LUnallocated(LUnallocated::FIXED_DOUBLE_REGISTER,
451 DoubleRegister::ToAllocationIndex(reg)); 445 DoubleRegister::ToAllocationIndex(reg));
452 } 446 }
(...skipping 1797 matching lines...) Expand 10 before | Expand all | Expand 10 after
2250 val = UseTempRegister(instr->value()); 2244 val = UseTempRegister(instr->value());
2251 } else if (instr->field_representation().IsDouble()) { 2245 } else if (instr->field_representation().IsDouble()) {
2252 val = UseRegisterAtStart(instr->value()); 2246 val = UseRegisterAtStart(instr->value());
2253 } else { 2247 } else {
2254 val = UseRegister(instr->value()); 2248 val = UseRegister(instr->value());
2255 } 2249 }
2256 2250
2257 // We need a temporary register for write barrier of the map field. 2251 // We need a temporary register for write barrier of the map field.
2258 LOperand* temp = needs_write_barrier_for_map ? TempRegister() : NULL; 2252 LOperand* temp = needs_write_barrier_for_map ? TempRegister() : NULL;
2259 2253
2260 // Add a deprecation dependency on the transition target map.
2261 if (instr->has_transition()) {
2262 AddDeprecationDependency(instr->transition_map());
2263 }
2264
2265 LInstruction* result = new(zone()) LStoreNamedField(obj, val, temp); 2254 LInstruction* result = new(zone()) LStoreNamedField(obj, val, temp);
2266 if (!instr->access().IsExternalMemory() && 2255 if (!instr->access().IsExternalMemory() &&
2267 instr->field_representation().IsHeapObject() && 2256 instr->field_representation().IsHeapObject() &&
2268 !instr->value()->type().IsHeapObject()) { 2257 !instr->value()->type().IsHeapObject()) {
2269 result = AssignEnvironment(result); 2258 result = AssignEnvironment(result);
2270 } 2259 }
2271 return result; 2260 return result;
2272 } 2261 }
2273 2262
2274 2263
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
2522 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2511 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2523 LOperand* object = UseRegister(instr->object()); 2512 LOperand* object = UseRegister(instr->object());
2524 LOperand* index = UseRegister(instr->index()); 2513 LOperand* index = UseRegister(instr->index());
2525 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index); 2514 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index);
2526 LInstruction* result = DefineSameAsFirst(load); 2515 LInstruction* result = DefineSameAsFirst(load);
2527 return AssignPointerMap(result); 2516 return AssignPointerMap(result);
2528 } 2517 }
2529 2518
2530 2519
2531 } } // namespace v8::internal 2520 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/mips/lithium-mips.h ('k') | src/x64/lithium-codegen-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698