Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Issue 263803005: Fix crash in debug builds introduced with r21110. (Closed)

Created:
6 years, 7 months ago by Benedikt Meurer
Modified:
6 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Fix crash in debug builds introduced with r21110. Basically we should not check for map deprecation during code selection, because that may run on the concurrent compiler thread. So the fix is to move this logic to the code generation phase instead, which is always run on the main thread. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21112

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -129 lines) Patch
M src/arm/lithium-arm.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/arm/lithium-arm.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M src/arm64/lithium-arm64.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M src/compiler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +1 line, -6 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M src/lithium-codegen.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/lithium-codegen.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/mips/lithium-mips.cc View 2 chunks +1 line, -12 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/x64/lithium-x64.cc View 2 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
Hey Michael, Here's the fix for the debug crash introduced with my last CL. As ...
6 years, 7 months ago (2014-05-02 07:50:27 UTC) #1
mvstanton
lgtm
6 years, 7 months ago (2014-05-02 07:53:38 UTC) #2
Benedikt Meurer
6 years, 7 months ago (2014-05-02 08:08:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21112 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698