third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h - Issue 2638013002: Record box shadow as main thread scrolling reasons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

Issue 2638013002: Record box shadow as main thread scrolling reasons (Closed)

Patch Set: Record box shadow from where it gets detected && remove translucent border Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

index 09662931475073ab2077ff2c2f53c418e49a8b56..84ffba5a1282e123a14f9c153a24229a1958bb47 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

@@ -197,7 +197,7 @@ class CORE_EXPORT LayoutBoxModelObject : public LayoutObject {

// Returns which layers backgrounds should be painted into for overflow

// scrolling boxes.

- BackgroundPaintLocation backgroundPaintLocation() const;

+ BackgroundPaintLocation backgroundPaintLocation(uint32_t* reasons = 0) const;

bokan 2017/01/23 19:55:51 nit: s/0/nullptr Also, please document what the m

yigu 2017/01/23 20:21:23 Done.

// These return the CSS computed padding values.

LayoutUnit computedCSSPaddingTop() const {