Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Side by Side Diff: third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

Issue 2638013002: Record box shadow as main thread scrolling reasons (Closed)
Patch Set: Record box shadow from where it gets detected && remove translucent border Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 1019 matching lines...) Expand 10 before | Expand all | Expand 10 after
1030 ASSERT_FALSE( 1030 ASSERT_FALSE(
1031 webScrollLayer->mainThreadScrollingReasons() & 1031 webScrollLayer->mainThreadScrollingReasons() &
1032 MainThreadScrollingReason::kHasNonLayerViewportConstrainedObjects); 1032 MainThreadScrollingReason::kHasNonLayerViewportConstrainedObjects);
1033 } 1033 }
1034 1034
1035 class StyleRelatedMainThreadScrollingReasonTest 1035 class StyleRelatedMainThreadScrollingReasonTest
1036 : public ScrollingCoordinatorTest { 1036 : public ScrollingCoordinatorTest {
1037 static const uint32_t m_LCDTextRelatedReasons = 1037 static const uint32_t m_LCDTextRelatedReasons =
1038 MainThreadScrollingReason::kHasOpacityAndLCDText | 1038 MainThreadScrollingReason::kHasOpacityAndLCDText |
1039 MainThreadScrollingReason::kHasTransformAndLCDText | 1039 MainThreadScrollingReason::kHasTransformAndLCDText |
1040 MainThreadScrollingReason::kBackgroundNotOpaqueInRectAndLCDText; 1040 MainThreadScrollingReason::kBackgroundNotOpaqueInRectAndLCDText |
1041 MainThreadScrollingReason::kHasBoxShadowAndLCDText;
1041 1042
1042 protected: 1043 protected:
1043 StyleRelatedMainThreadScrollingReasonTest() { 1044 StyleRelatedMainThreadScrollingReasonTest() {
1044 registerMockedHttpURLLoad("two_scrollable_area.html"); 1045 registerMockedHttpURLLoad("two_scrollable_area.html");
1045 navigateTo(m_baseURL + "two_scrollable_area.html"); 1046 navigateTo(m_baseURL + "two_scrollable_area.html");
1046 } 1047 }
1047 void testStyle(const std::string& target, const uint32_t reason) { 1048 void testStyle(const std::string& target, const uint32_t reason) {
1048 webViewImpl()->settings()->setPreferCompositingToLCDTextEnabled(false); 1049 webViewImpl()->settings()->setPreferCompositingToLCDTextEnabled(false);
1049 Document* document = frame()->document(); 1050 Document* document = frame()->document();
1050 Element* container = document->getElementById("scroller1"); 1051 Element* container = document->getElementById("scroller1");
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
1147 forceFullCompositingUpdate(); 1148 forceFullCompositingUpdate();
1148 ASSERT_FALSE(frameView->mainThreadScrollingReasons() & reason); 1149 ASSERT_FALSE(frameView->mainThreadScrollingReasons() & reason);
1149 } 1150 }
1150 1151
1151 TEST_F(StyleRelatedMainThreadScrollingReasonTest, LCDTextEnabledTest) { 1152 TEST_F(StyleRelatedMainThreadScrollingReasonTest, LCDTextEnabledTest) {
1152 testStyle("transparent border-radius", 1153 testStyle("transparent border-radius",
1153 MainThreadScrollingReason::kHasOpacityAndLCDText | 1154 MainThreadScrollingReason::kHasOpacityAndLCDText |
1154 MainThreadScrollingReason::kHasBorderRadius); 1155 MainThreadScrollingReason::kHasBorderRadius);
1155 } 1156 }
1156 1157
1158 TEST_F(StyleRelatedMainThreadScrollingReasonTest, BoxShadowTest) {
1159 testStyle("box-shadow", MainThreadScrollingReason::kHasBoxShadowAndLCDText);
1160 }
1161
1157 } // namespace blink 1162 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698