Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2637993002: VM: [Kernel] Ensure we have correct try-index on join blocks for break destinations (Closed)

Created:
3 years, 11 months ago by kustermann
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: [Kernel] Ensure we have correct try-index on join blocks for break destinations R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/f40e46c3fde3082c71d33871ba927b31452d2b7a

Patch Set 1 #

Patch Set 2 : Mark 2 tests as Dartk issue #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M runtime/vm/kernel_to_il.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/kernel_to_il.cc View 7 chunks +13 lines, -4 lines 2 comments Download
M tests/language/language_kernel.status View 1 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kustermann
3 years, 11 months ago (2017-01-17 12:07:03 UTC) #3
Vyacheslav Egorov (Google)
LGTM https://codereview.chromium.org/2637993002/diff/40001/runtime/vm/kernel_to_il.cc File runtime/vm/kernel_to_il.cc (right): https://codereview.chromium.org/2637993002/diff/40001/runtime/vm/kernel_to_il.cc#newcode774 runtime/vm/kernel_to_il.cc:774: intptr_t try_index_; const? https://codereview.chromium.org/2637993002/diff/40001/runtime/vm/kernel_to_il.cc#newcode851 runtime/vm/kernel_to_il.cc:851: intptr_t try_index_; const?
3 years, 11 months ago (2017-01-17 22:24:08 UTC) #4
kustermann
3 years, 11 months ago (2017-01-18 10:26:05 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as
f40e46c3fde3082c71d33871ba927b31452d2b7a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698