Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2637753003: Ast changes to support the covariant keyword (Closed)

Created:
3 years, 11 months ago by Brian Wilkerson
Modified:
3 years, 11 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M pkg/analyzer/lib/dart/ast/ast.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast.dart View 3 chunks +11 lines, -0 lines 2 comments Download

Messages

Total messages: 8 (3 generated)
Brian Wilkerson
I didn't update either the constructors or the factory methods. Not doing so seems better ...
3 years, 11 months ago (2017-01-16 23:25:21 UTC) #2
Paul Berry
lgtm
3 years, 11 months ago (2017-01-17 13:28:00 UTC) #3
Brian Wilkerson
Committed patchset #1 (id:1) manually as 38264a14630a4833c9b5c4bc3ce8949d6cfe395b (presubmit successful).
3 years, 11 months ago (2017-01-17 14:44:49 UTC) #5
scheglov
https://codereview.chromium.org/2637753003/diff/1/pkg/analyzer/lib/src/dart/ast/ast.dart File pkg/analyzer/lib/src/dart/ast/ast.dart (right): https://codereview.chromium.org/2637753003/diff/1/pkg/analyzer/lib/src/dart/ast/ast.dart#newcode8181 pkg/analyzer/lib/src/dart/ast/ast.dart:8181: result.add(covariantKeyword); Do we need to update beginToken?
3 years, 11 months ago (2017-01-18 04:29:59 UTC) #7
Brian Wilkerson
3 years, 11 months ago (2017-01-18 17:19:30 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/2637753003/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/ast/ast.dart (right):

https://codereview.chromium.org/2637753003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/ast/ast.dart:8181: result.add(covariantKeyword);
Yes. Good catch. I'll have an update out shortly.

Powered by Google App Engine
This is Rietveld 408576698