ServiceWorker: remove EmbeddedWorkerMsg_StartWorker

content/browser/service_worker/embedded_worker_instance.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SERVICE_WORKER_EMBEDDED_WORKER_INSTANCE_H_
 #define CONTENT_BROWSER_SERVICE_WORKER_EMBEDDED_WORKER_INSTANCE_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 198 matching lines @@
   void OnProcessAllocated(std::unique_ptr<WorkerProcessHandle> handle,
                           ServiceWorkerMetrics::StartSituation start_situation);
 
   // Called back from StartTask after the worker is registered to
   // WorkerDevToolsManager.
   void OnRegisteredToDevToolsManager(bool is_new_process,
                                      int worker_devtools_agent_route_id,
                                      bool wait_for_debugger);
 
   // Sends StartWorker message via Mojo.
-  ServiceWorkerStatusCode SendMojoStartWorker(
+  ServiceWorkerStatusCode SendStartWorker(
       std::unique_ptr<EmbeddedWorkerStartParams> params);
 
   // Called back from StartTask after a start worker message is sent.
   void OnStartWorkerMessageSent();
 
   // Called back from Registry when the worker instance has ack'ed that
   // it is ready for inspection.
   void OnReadyForInspection();
 
   // Called back from Registry when the worker instance has ack'ed that
@@ skipping 70 matching lines @@
   int restart_count_;
 
   // Current running information.
   std::unique_ptr<EmbeddedWorkerInstance::WorkerProcessHandle> process_handle_;
   int thread_id_;
 
   // |client_| is used to send messages to the renderer process.
   mojom::EmbeddedWorkerInstanceClientPtr client_;
 
   // TODO(shimazu): Remove this after non-mojo StartWorker is removed.
   mojom::ServiceWorkerEventDispatcherRequest pending_dispatcher_request_;

[falken, 2017/01/16 06:02:51]

Can this be removed now? If not, the TODO needs updating.

[shimazu, 2017/01/16 07:06:38]

It will be a bit big patch because currently EmbeddedWorkerStartParams is still
on embedded_worker_messages.h instead of typemap for mojo, and the request
cannot be included in the EWStartParams. 
Updated the comment.

 
   // Whether devtools is attached or not.
   bool devtools_attached_;
 
   // True if the script load request accessed the network. If the script was
   // served from HTTPCache or ServiceWorkerDatabase this value is false.
   bool network_accessed_for_script_;
 
   ListenerList listener_list_;
   std::unique_ptr<DevToolsProxy> devtools_proxy_;
 
   std::unique_ptr<StartTask> inflight_start_task_;
 
   // This is valid only after a process is allocated for the worker.
   ServiceWorkerMetrics::StartSituation start_situation_ =
       ServiceWorkerMetrics::StartSituation::UNKNOWN;
 
   // Used for UMA. The start time of the current start sequence step.
   base::TimeTicks step_time_;
 
   base::WeakPtrFactory<EmbeddedWorkerInstance> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(EmbeddedWorkerInstance);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SERVICE_WORKER_EMBEDDED_WORKER_INSTANCE_H_