Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1459)

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner.cc

Issue 2637563002: [Offline Pages] Snapshotting on timeout of last retry. (Closed)
Patch Set: merging with master again Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_offliner.cc
diff --git a/chrome/browser/android/offline_pages/prerendering_offliner.cc b/chrome/browser/android/offline_pages/prerendering_offliner.cc
index 5ceaf65abb73b74ad687d0f6a7122477991bb41d..e7ee1f979c2c3d4737f8d9404f6b5a77c4a483ce 100644
--- a/chrome/browser/android/offline_pages/prerendering_offliner.cc
+++ b/chrome/browser/android/offline_pages/prerendering_offliner.cc
@@ -10,6 +10,7 @@
#include "chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h"
#include "chrome/browser/android/offline_pages/offliner_helper.h"
#include "chrome/browser/profiles/profile.h"
+#include "components/offline_pages/core/background/offliner_policy.h"
#include "components/offline_pages/core/background/save_page_request.h"
#include "components/offline_pages/core/client_namespace_constants.h"
#include "components/offline_pages/core/downloads/download_ui_adapter.h"
@@ -27,6 +28,7 @@ PrerenderingOffliner::PrerenderingOffliner(
const OfflinerPolicy* policy,
OfflinePageModel* offline_page_model)
: browser_context_(browser_context),
+ policy_(policy),
offline_page_model_(offline_page_model),
pending_request_(nullptr),
is_low_end_device_(base::SysInfo::IsLowEndDevice()),
@@ -220,6 +222,20 @@ void PrerenderingOffliner::Cancel() {
}
}
+bool PrerenderingOffliner::HandleTimeout(const SavePageRequest& request) {
+ if (pending_request_) {
+ DCHECK(request.request_id() == pending_request_->request_id());
+ if (GetOrCreateLoader()->IsLowbarMet() &&
+ (request.started_attempt_count() + 1 >= policy_->GetMaxStartedTries() ||
+ request.completed_attempt_count() + 1 >=
+ policy_->GetMaxCompletedTries())) {
+ GetOrCreateLoader()->StartSnapshot();
+ return true;
+ }
+ }
+ return false;
+}
+
void PrerenderingOffliner::SetLoaderForTesting(
std::unique_ptr<PrerenderingLoader> loader) {
DCHECK(!loader_);

Powered by Google App Engine
This is Rietveld 408576698