Introduce the interface NamedType as a replacement for TypeName

Introduce the interface NamedType as a replacement for TypeName

R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/483304074992d7d4b483aba137b9c50d65217518

[Brian Wilkerson, 2017-01-13 23:38:44]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2017-01-14 13:57:14]

lgtm.

Here's a suggestion for a follow-up CL that I think would help ease the
transition (perhaps you are already thinking along similar lines):

- Change TypeName to be an empty class that simply extends NamedType.

- Leave TypeNameImpl alone (it still implements TypeName; now it implicitly
implements NamedType too).

- Change the type of AstVisitor.visitTypeName to reference NamedType instead of
TypeName.

After that CL is published, we can start incrementally eliminating references to
TypeName in client code (replacing them with references to NamedType or
GenericFunctionType as appropriate), and we won't introduce any breakages.  Then
once all client code is updated we can remove the old TypeName class.

WDYT?

[Brian Wilkerson, 2017-01-16 19:03:08]

Description was changed from

==========
Introduce the interface NamedType as a replacement for TypeName
==========

to

==========
Introduce the interface NamedType as a replacement for TypeName

R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/483304074992d7d4b483aba137b9c50d65217518
==========

[Brian Wilkerson, 2017-01-16 19:03:10]

Committed patchset #1 (id:1) manually as
483304074992d7d4b483aba137b9c50d65217518 (presubmit successful).

[Brian Wilkerson, 2017-01-16 19:05:30]

I actually implemented something very similar to that the first time around, but
after migrating dart_style and linter, realizing that they both need to support
both versions of the code for a while, I decided that it was much easier to
catch errors if the old and new classes are not related.